Fix AWS Sdk dependency conflict #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb2k16
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
previously approved these changes
Oct 17, 2024
san81
reviewed
Oct 17, 2024
| @@ -138,7 +138,7 @@ public Scheduler getScheduler(final Buffer<Record<Event>> buffer) { | |||
| try { | |||
| scheduler = createScheduler(buffer); | |||
| } catch (Exception ex) { | |||
| LOG.error("Caught exception when initializing KCL Scheduler. Will retry"); | |||
| LOG.error("Caught exception when initializing KCL Scheduler. Will retry", ex); | |||
There was a problem hiding this comment.
Thanks for adding ex to this message. Also, please add NOISY flag for this message.
kkondaka
previously approved these changes
Oct 17, 2024
Signed-off-by: Souvik Bose <souvbose@amazon.com>
sb2k16
force-pushed
the
fix-dependency-conflict
branch
from
784b4d0 to
b3d4dfb
Compare
san81
approved these changes
Oct 17, 2024
dlvenable
approved these changes
Oct 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Souvik Bose <souvbose@amazon.com> Co-authored-by: Souvik Bose <souvbose@amazon.com> (cherry picked from commit 2575db3)
dlvenable
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to address the dependency conflict in Kinesis Source plugin. It looks there is a conflict of AWS Sdk Kinesls Client dependency which was breaking the plugin functionality.
Resolves #5084
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.