Add acknowledgement support to aggregate processor #5139
Conversation
| @@ -62,6 +82,7 @@ boolean shouldConcludeGroup(final Duration groupDuration) { | |||
|
|
|||
| void resetGroup() { | |||
| groupStart = Instant.now(); | |||
| this.eventHandle = new AggregateEventHandle(groupStart); | |||
There was a problem hiding this comment.
Should this do something with the old eventHandle? Release it? Something else?
There was a problem hiding this comment.
No. The previous event handle was sent with the concluded event and will be released after the event is sent to Sink. Every "aggregate duration" ONE aggregated event is created and one aggregate event handle is created. The aggregate event handle is attached to the aggregated event and the group will create a new handle for the new duration. If the event handle is not attached to any event, then it will be freed (by garbage collector) when a new event handle is created in resetGroup.
There was a problem hiding this comment.
Thanks for the explanation. This is clear. To be sure, are there any paths that could lead to resetting a group where we do need to handle the aggregate event?
There was a problem hiding this comment.
It doesn't look like it. It looks like resetGroup() is called only in closeGroup() which is called only when the group is concluded.
| @@ -26,6 +26,14 @@ public interface Processor<InputRecord extends Record<?>, OutputRecord extends R | |||
| */ | |||
| Collection<OutputRecord> execute(Collection<InputRecord> records); | |||
|
|
|||
| /** | |||
| * indicates if the processor holds the events or not | |||
There was a problem hiding this comment.
Update this to be a little clear on what it means to hold events.
dlvenable
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
KarstenSchnitter and
oeyh
as code owners
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
Description
Add acknowledgement support to aggregate processor
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.