Fix lambda metrics #5201
Merged
Fix lambda metrics #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkondaka
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Nov 18, 2024
| @@ -30,8 +30,12 @@ public abstract class AbstractSink<T extends Record<?>> implements Sink<T> { | |||
| private int waitTimeMs; | |||
| private SinkThread sinkThread; | |||
|
|
|||
| protected String getName(final PluginSetting pluginSetting) { | |||
There was a problem hiding this comment.
I don't think we should change AbstractSink for renaming. Rather, let the concrete sink pass in the PluginMetrics. Then handle the renaming in the LambdaSink directly.
super(pluginSetting, PluginMettrics.fromPluginSetting(pluginSetting));
Signed-off-by: Kondaka <krishkdk@amazon.com>
kkondaka
force-pushed
the
lambda-metrics-fix
branch
from
0d1cbb1 to
482f65c
Compare
Signed-off-by: Kondaka <krishkdk@amazon.com>
Signed-off-by: Kondaka <krishkdk@amazon.com>
san81
reviewed
Nov 19, 2024
| @@ -49,6 +49,8 @@ | |||
| import software.amazon.awssdk.services.lambda.LambdaAsyncClient; | |||
| import software.amazon.awssdk.services.lambda.model.InvokeResponse; | |||
|
|
|||
| import javax.management.RuntimeMBeanException; | |||
There was a problem hiding this comment.
Seems like unwanted unused import. Please remove it.
san81
approved these changes
Nov 19, 2024
dlvenable
requested changes
Nov 19, 2024
| if (response.payload() != null) { | ||
| responsePayloadMetric.record(response.payload().asByteArray().length); | ||
| } | ||
| continue; |
There was a problem hiding this comment.
Please remove this continue. It is likely to cause bugs later on.
| if (response.payload() != null) { | ||
| responsePayloadMetric.record(response.payload().asByteArray().length); | ||
| } | ||
| continue; |
There was a problem hiding this comment.
Please remove this continue and use the catch to increment. This approach is likely to lead to future code bugs.
There was a problem hiding this comment.
Santhosh's next PR is taking care of this - https://github.com/kkondaka/kk-data-prepper-f2/pull/1/files
dlvenable
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix lambda metrics.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.