otel trace source and otel metrics source test coverage #5242
+220
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…csSource authentication Signed-off-by: Jeremy Michael <jsusanto@amazon.com>
jmsusanto
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
chenqi0805
reviewed
Dec 3, 2024
| } | ||
|
|
||
| @Test | ||
| void testHttpsFullJsonWithCustomPathAndAuthHeaderAndSsl_with_unsuccessful_response() throws InvalidProtocolBufferException { |
There was a problem hiding this comment.
Are we testing missing credentials (username/password) in this test case? If yes, I would suggest rename the test. If not, missing credentials in client can have a confounding factor causing unauth.
There was a problem hiding this comment.
this is meant for testing that if SSL is enabled on the server and a client attempts to connect without using SSL/TLS ], the connection will fail as expected. Made changes accordingly
| } | ||
|
|
||
| @Test | ||
| void testHttpsFullJsonWithCustomPathAndAuthHeaderAndSsl_with_unsuccessful_response() throws Exception { |
Signed-off-by: Jeremy Michael <jsusanto@amazon.com>
chenqi0805
approved these changes
Dec 4, 2024
KarstenSchnitter
approved these changes
Dec 11, 2024
sb2k16
pushed a commit
to sb2k16/data-prepper
that referenced
this pull request
Dec 13, 2024
…roject#5242) Added security/authentication tests for OtelTraceSource and OTelMetricsSource authentication Signed-off-by: Jeremy Michael <jsusanto@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding additional test coverage for otel trace source and otel metrics source. Tests are for authentication handling and SSL/TLS validation
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.