Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Document new configuration value “data.search.usageTelemetry.enabled” in the opensearch_dashboard.yml #494

Closed
Flyingliuhub opened this issue Apr 7, 2022 · 12 comments · Fixed by #594
Assignees
Labels
Closed - Complete Issue: Work is done and associated PRs closed enhancement New feature or request v2.0.0
Milestone

Comments

@Flyingliuhub
Copy link
Member

Flyingliuhub commented Apr 7, 2022

Is your feature request related to a problem?
Yes. this feature request related with issue #928 , and PR address the issue #928. Added configuration value “data.search.usageTelemetry.enabled” to opensearch_dashboard.yml, which customer can opt in/out with search usage telemetry by modifying the data.search.usageTelemetry.enabled value in the opensearch_dashboard.yml.

opensearch_dashboard.yml enabled value data plugin config enabled value Search usage telemetry
TRUE FALSE OPT IN
FALSE FALSE OPT OUT
TRUE TRUE OPT IN
FALSE TRUE OPT OUT
NONE TRUE OPT IN
NONE FALSE OPT OUT

What solution would you like?
We add configuration value “data.search.usageTelemetry.enabled” to allow customer to opt in/out search usage telemetry, and changed the default behavior to false, which turn off search usage telemetry as large traffic for the opensearch cluster, it can improve the performance of cluster.

What alternatives have you considered?
N/A

Do you have any additional context?
This feature target at release 2.0.0, I don't have permission to change the label, can someone change this feature's labels to 2.0.0. Thanks

@Flyingliuhub Flyingliuhub added enhancement New feature or request untriaged labels Apr 7, 2022
@Flyingliuhub Flyingliuhub changed the title [FEATURE] Document [FEATURE] Document new configuration value “data.search.usageTelemetry.enabled” in the opensearch_dashboard.yml Apr 7, 2022
@Naarcha-AWS
Copy link
Collaborator

Label added. Thanks for submitting this issue @Flyingliuhub

@alicejw1 alicejw1 self-assigned this May 2, 2022
@hdhalter hdhalter added this to the v2.0.0 milestone May 16, 2022
@alicejw1
Copy link
Contributor

hi @Flyingliuhub , could you please share an example opensearch_dashboard.yml file with the configuration setting?

I'd like to add it to the documentation as an example.
Thanks

@Flyingliuhub
Copy link
Member Author

Flyingliuhub commented May 20, 2022

Yes. the sample opensearch_dashboard.yml in the https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/config/opensearch_dashboards.yml#L180.

  1. enable usageTelemetry
    data.search.usageTelemetry.enabled: true

  2. default behavior is disabled, it is meaning that customer didn't need to change opensearch_dashboard.yml

alicejw1 added a commit to alicejw1/documentation-website that referenced this issue May 20, 2022
Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1
Copy link
Contributor

Hi Tao, thanks for the quick reply! @Flyingliuhub

@alicejw1
Copy link
Contributor

Hi @Flyingliuhub Tao, could you look at my PR 594 for this issue, and let me know your feedback? Thanks

@Flyingliuhub
Copy link
Member Author

Yes. I just leave some comments on your PR.

@alicejw1
Copy link
Contributor

alicejw1 commented May 20, 2022

Hi @Flyingliuhub could you help us locate the "data plugin"
I see the config file, but just wondering if there is an official plugin name?

I looked in current docs, and found a Trace analytics dashboard plugin that is related to telemetry. Is this the "data plugin" ?
Thanks

@Flyingliuhub
Copy link
Member Author

The configuration file is under https://github.com/opensearch-project/OpenSearch-Dashboards/tree/main/src/plugins/data
"The data plugin provides common data access services, such as search and query, for solutions and application developers.", which readme called the data plugin. it is not Trace analytics dashboard plugin

@alicejw1
Copy link
Contributor

Thanks Tao Liu @Flyingliuhub i really appreciate your help.

@alicejw1
Copy link
Contributor

alicejw1 commented May 20, 2022

Hi @Flyingliuhub, one last question - so i can show customers how to enable telemetry in the data config file. (already showed them how to do in YAML file).
Do they just change this entry to "true?"
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data/config.ts

usageTelemetry: schema.object({
  enabled: schema.boolean({ defaultValue: false }),

@Flyingliuhub
Copy link
Member Author

I don't think that we need to show customer how to enable it in the data config file. you already have yaml matrix above, it is configuration combination, if you need to show user how to enable it in the data configuration, the user need to check if opensearch_dashboards.yml have value to override here, the value is passed from top to bottom, and user cannot change here, they just need to change the opensearch_dashboards.yml to enable it if they need.

@Flyingliuhub
Copy link
Member Author

the value form data configuration just tell user that the default behavior is disabled, if you don't change anything.

@hdhalter hdhalter added the Closed - Complete Issue: Work is done and associated PRs closed label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed - Complete Issue: Work is done and associated PRs closed enhancement New feature or request v2.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants