-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Document new configuration value “data.search.usageTelemetry.enabled” in the opensearch_dashboard.yml #494
Comments
Label added. Thanks for submitting this issue @Flyingliuhub |
hi @Flyingliuhub , could you please share an example opensearch_dashboard.yml file with the configuration setting? I'd like to add it to the documentation as an example. |
Yes. the sample opensearch_dashboard.yml in the https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/config/opensearch_dashboards.yml#L180.
|
Signed-off-by: alicejw <alicejw@amazon.com>
Hi Tao, thanks for the quick reply! @Flyingliuhub |
Hi @Flyingliuhub Tao, could you look at my PR 594 for this issue, and let me know your feedback? Thanks |
Yes. I just leave some comments on your PR. |
Hi @Flyingliuhub could you help us locate the "data plugin" I looked in current docs, and found a Trace analytics dashboard plugin that is related to telemetry. Is this the "data plugin" ? |
The configuration file is under https://github.com/opensearch-project/OpenSearch-Dashboards/tree/main/src/plugins/data |
Thanks Tao Liu @Flyingliuhub i really appreciate your help. |
Hi @Flyingliuhub, one last question - so i can show customers how to enable telemetry in the data config file. (already showed them how to do in YAML file).
|
I don't think that we need to show customer how to enable it in the data config file. you already have yaml matrix above, it is configuration combination, if you need to show user how to enable it in the data configuration, the user need to check if opensearch_dashboards.yml have value to override here, the value is passed from top to bottom, and user cannot change here, they just need to change the opensearch_dashboards.yml to enable it if they need. |
the value form data configuration just tell user that the default behavior is disabled, if you don't change anything. |
Is your feature request related to a problem?
Yes. this feature request related with issue #928 , and PR address the issue #928. Added configuration value “data.search.usageTelemetry.enabled” to opensearch_dashboard.yml, which customer can opt in/out with search usage telemetry by modifying the data.search.usageTelemetry.enabled value in the opensearch_dashboard.yml.
What solution would you like?
We add configuration value “data.search.usageTelemetry.enabled” to allow customer to opt in/out search usage telemetry, and changed the default behavior to false, which turn off search usage telemetry as large traffic for the opensearch cluster, it can improve the performance of cluster.
What alternatives have you considered?
N/A
Do you have any additional context?
This feature target at release 2.0.0, I don't have permission to change the label, can someone change this feature's labels to 2.0.0. Thanks
The text was updated successfully, but these errors were encountered: