Add the two clear cache APIs. #1093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Murphy <stevemurphy@BCSR-11413.local>
|
@Steve-O-Murphy -Is this ready for review? |
|
@hdhalter Yes, it is. |
alicejw1
reviewed
Sep 9, 2022
| | Parameter | Data Type | Description | | ||
| :--- | :--- | :--- | ||
| | allow_no_indices | Boolean | Whether to ignore wildcards, index aliases, or `_all` target (`target` path parameter) values that don’t match any indices. If `false`, the request returns an error if any wildcard expression, index alias, or `_all` target values don't match any indices. This behavior also applies if the request targets include other open indices. For example, a request where the target is `fig*,app*` returns an error if an index starts with `fig` but no index starts with `app`. Defaults to `true`. | | ||
| | expand_wildcards | String | Determines the index types that wildcard expressions can expand to. Accepts multiple values separated by a comma, such as `open,hidden`. Valid values are: <br /><br /> all - Expand to open, closed,and hidden indices.<br /><br />open - Expand only to open indices.<br /><br />closed - Expand only to close indices<br /><br />hidden - Expand to include hidden indices. Must be combined with `open`, `closed`, or `both`.<br /><br />none - Expansions are not accepted.<br /><br /> Defaults to `open`. | |
There was a problem hiding this comment.
Suggested change
| | expand_wildcards | String | Determines the index types that wildcard expressions can expand to. Accepts multiple values separated by a comma, such as `open,hidden`. Valid values are: <br /><br /> all - Expand to open, closed,and hidden indices.<br /><br />open - Expand only to open indices.<br /><br />closed - Expand only to close indices<br /><br />hidden - Expand to include hidden indices. Must be combined with `open`, `closed`, or `both`.<br /><br />none - Expansions are not accepted.<br /><br /> Defaults to `open`. | | |
| | expand_wildcards | String | Determines the index types that wildcard expressions can expand to. Accepts multiple values separated by a comma, such as `open,hidden`. Valid values are: <br /><br /> `all` - Expand to open, closed, and hidden indices.<br /><br />`open` - Expand only to open indices.<br /><br />`closed` - Expand only to close indices<br /><br />`hidden` - Expand to include hidden indices. Must be combined with `open`, `closed`, or `both`.<br /><br />`none` - Expansions are not accepted.<br /><br /> Defaults to `open`. | |
There was a problem hiding this comment.
suggest to add code font to all values
There was a problem hiding this comment.
I have made the changes.
alicejw1
reviewed
Sep 9, 2022
| ```` | ||
|
|
||
| ##### Clear caches for all data streams and indices | ||
|
|
There was a problem hiding this comment.
(add the descriptive sentence)
"The following request clears the cache for all data streams and indexes:"
alicejw1
reviewed
Sep 9, 2022
| ```` | ||
|
|
||
| ##### Clear caches for specific data streams and indices | ||
|
|
There was a problem hiding this comment.
(add the descriptive sentence)
"The following request clears the cache for two specific indexes:"
There was a problem hiding this comment.
I added the descriptive sentence and made it slightly more specific:
The following request clears caches and data streams for my-index and my-index2:
alicejw1
approved these changes
Sep 9, 2022
Signed-off-by: Steve Murphy <stevemurphy@BCSR-11413.local>
|
Thanks for the great comments, @alicejw-aws! |
|
@alicejw-aws and @hdhalter I've pushed changes to the repo. |
|
Thanks for your help Steve! Alice made additional changes in a different PR. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Murphy stevemurphy@BCSR-11413.local
Description
Added the
POST /<target>/_cache/clearandPOST /_cache/clearAPIs. Both are in one file.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.