-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear cache API - additional edits #1214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: alicejw <alicejw@amazon.com>
9c7c003
to
321d8b9
Compare
@@ -8,34 +8,38 @@ nav_order: 320 | |||
|
|||
## Clear index or data stream cache | |||
|
|||
Clears the caches of one or more indexes. For data streams, the API clears the caches of the stream’s backing indexes. | |||
The cache clear API operation clears the caches of one or more indexes. For data streams, the API clears the caches of the stream’s backing indexes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"clear cache API"? That's how it's used below and I think it is more understandable in that order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One small comment.
Signed-off-by: alicejw <alicejw@amazon.com>
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65)
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65)
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65)
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65)
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65)
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65) Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65) Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65) Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65) Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> (cherry picked from commit 63e1a65) Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: Mark Cohen <markcoh@amazon.com>
* to check in the cache API for Steve Signed-off-by: alicejw <alicejw@amazon.com> * for editorial review feedback modifications Signed-off-by: alicejw <alicejw@amazon.com> * doc review update Signed-off-by: alicejw <alicejw@amazon.com> Signed-off-by: alicejw <alicejw@amazon.com>
Description
Editorial review comments for Add the two clear cache APIs PR
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.