Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cache API - additional edits #1214

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

alicejw1
Copy link
Contributor

@alicejw1 alicejw1 commented Sep 14, 2022

Description

Editorial review comments for Add the two clear cache APIs PR

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@alicejw1 alicejw1 self-assigned this Sep 14, 2022
@alicejw1 alicejw1 added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 labels Sep 14, 2022
@alicejw1 alicejw1 marked this pull request as ready for review September 14, 2022 19:47
@alicejw1 alicejw1 requested a review from a team as a code owner September 14, 2022 19:48
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: alicejw <alicejw@amazon.com>
@@ -8,34 +8,38 @@ nav_order: 320

## Clear index or data stream cache

Clears the caches of one or more indexes. For data streams, the API clears the caches of the stream’s backing indexes.
The cache clear API operation clears the caches of one or more indexes. For data streams, the API clears the caches of the stream’s backing indexes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"clear cache API"? That's how it's used below and I think it is more understandable in that order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small comment.

Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1 alicejw1 merged commit 63e1a65 into opensearch-project:main Sep 14, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 14, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 14, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 14, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 14, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 14, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)
alicejw1 added a commit that referenced this pull request Sep 15, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)

Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
alicejw1 added a commit that referenced this pull request Sep 15, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)

Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
alicejw1 added a commit that referenced this pull request Sep 15, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)

Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
alicejw1 added a commit that referenced this pull request Sep 15, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)

Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
Naarcha-AWS pushed a commit that referenced this pull request Sep 15, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
(cherry picked from commit 63e1a65)

Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
macohen pushed a commit to macohen/documentation-website that referenced this pull request Sep 21, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Naarcha-AWS pushed a commit that referenced this pull request Oct 6, 2022
* to check in the cache API for Steve

Signed-off-by: alicejw <alicejw@amazon.com>

* for editorial review feedback modifications

Signed-off-by: alicejw <alicejw@amazon.com>

* doc review update

Signed-off-by: alicejw <alicejw@amazon.com>

Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1 alicejw1 deleted the clear-cache-api branch December 9, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants