Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Update Wizard naming convention #1808

Merged
merged 10 commits into from
Nov 8, 2022
Merged

[DOC]: Update Wizard naming convention #1808

merged 10 commits into from
Nov 8, 2022

Conversation

vagimeli
Copy link
Collaborator

@vagimeli vagimeli commented Nov 3, 2022

Signed-off-by: vagimeli vagimeli@amazon.com

Description

Revised documentation to update naming convention for Wizard visualization type.

Issues Resolved

#1198
opensearch-project/OpenSearch-Dashboards#1157
opensearch-project/OpenSearch-Dashboards#2645 (comment)

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: vagimeli <vagimeli@amazon.com>
@vagimeli vagimeli requested a review from a team as a code owner November 3, 2022 22:36
@vagimeli vagimeli self-assigned this Nov 3, 2022
@vagimeli vagimeli added 2 - In progress Issue/PR: The issue or PR is in progress. 3 - Tech review PR: Tech review in progress labels Nov 3, 2022
@vagimeli vagimeli added this to the v2.4 milestone Nov 3, 2022
Signed-off-by: vagimeli <vagimeli@amazon.com>
Signed-off-by: vagimeli <vagimeli@amazon.com>

<img src="{{site.url}}{{site.baseurl}}/images/enable-experimental-viz.png" alt="Enable experimental visualizations" width="550">

3. From the top menu, select **Visualize** **>** **Create visualization** **>** **Wizard**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should not be Wizard anymore, it should VisBuilder? @ashwin-pc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

_dashboards/visbuilder.md Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Show resolved Hide resolved

<img src="{{site.url}}{{site.baseurl}}/images/enable-experimental-viz.png" alt="Enable experimental visualizations" width="550">

3. From the top menu, select **Visualize** **>** **Create visualization** **>** **Wizard**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Show resolved Hide resolved
Signed-off-by: vagimeli <vagimeli@amazon.com>
Signed-off-by: vagimeli <vagimeli@amazon.com>
@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress 4 - Doc review PR: Doc review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. 3 - Tech review PR: Tech review in progress labels Nov 7, 2022
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a couple of tweaks.

_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Show resolved Hide resolved
@vagimeli vagimeli removed the 4 - Doc review PR: Doc review in progress label Nov 8, 2022
Signed-off-by: vagimeli <vagimeli@amazon.com>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Please see my comments and changes and let me know if you have any questions. Thanks!

_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
_dashboards/visbuilder.md Outdated Show resolved Hide resolved
@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Nov 8, 2022
Signed-off-by: vagimeli <vagimeli@amazon.com>
Signed-off-by: vagimeli <vagimeli@amazon.com>
@vagimeli vagimeli added the 6 - Done but waiting to merge PR: The work is done and ready to merge label Nov 8, 2022
Copy link
Contributor

@ariamarble ariamarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: vagimeli <vagimeli@amazon.com>
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise LGTM

_dashboards/visbuilder.md Show resolved Hide resolved
Signed-off-by: vagimeli <vagimeli@amazon.com>
@vagimeli vagimeli merged commit 71608d4 into main Nov 8, 2022
@vagimeli vagimeli added Closed - Complete Issue: Work is done and associated PRs closed and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Nov 8, 2022
@Naarcha-AWS Naarcha-AWS deleted the Issue-1198 branch December 13, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed - Complete Issue: Work is done and associated PRs closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants