Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes max_primary_shard_size parameter #1914

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Removes max_primary_shard_size parameter #1914

merged 2 commits into from
Nov 28, 2022

Conversation

kolchfa-aws
Copy link
Collaborator

Removes the max_primary_shard_size parameter because this parameter does not exist for this API.

Checklist

  • [x ] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@kolchfa-aws kolchfa-aws requested a review from a team as a code owner November 16, 2022 16:05
@kolchfa-aws kolchfa-aws self-assigned this Nov 16, 2022
@kolchfa-aws kolchfa-aws added 3 - Tech review PR: Tech review in progress backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 labels Nov 16, 2022
@msfroh
Copy link
Contributor

msfroh commented Nov 16, 2022

Related to opensearch-project/OpenSearch#5170

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@kolchfa-aws
Copy link
Collaborator Author

The new parameter will be added in this PR: opensearch-project/OpenSearch#5229

@kolchfa-aws kolchfa-aws added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Nov 16, 2022
@kolchfa-aws kolchfa-aws merged commit cb9b5a6 into main Nov 28, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 28, 2022
* Removes max_primary_shard_size parameter

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Added a comment on the new parameter

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit cb9b5a6)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 28, 2022
* Removes max_primary_shard_size parameter

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Added a comment on the new parameter

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit cb9b5a6)
kolchfa-aws added a commit that referenced this pull request Nov 28, 2022
* Removes max_primary_shard_size parameter

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Added a comment on the new parameter

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit cb9b5a6)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Nov 28, 2022
* Removes max_primary_shard_size parameter

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Added a comment on the new parameter

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit cb9b5a6)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS deleted the remove-parameter branch December 13, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants