Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian OSD Install Guide - Editorial changes #2454

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

JeffHuss
Copy link

Description

Applying editorial changes.

Issues Resolved

Fixes #2439

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
@JeffHuss JeffHuss added the 4 - Doc review PR: Doc review in progress label Jan 23, 2023
@JeffHuss JeffHuss added this to the v2.5.x milestone Jan 23, 2023
@JeffHuss JeffHuss requested a review from a team as a code owner January 23, 2023 18:30
@JeffHuss JeffHuss self-assigned this Jan 23, 2023
@JeffHuss
Copy link
Author

Fixes from PR #2440

Copy link
Contributor

@carolxob carolxob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Jeff!

@JeffHuss JeffHuss merged commit 894b561 into main Jan 23, 2023
vagimeli pushed a commit that referenced this pull request Jan 25, 2023
Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
vagimeli added a commit that referenced this pull request Jan 26, 2023
vagimeli pushed a commit that referenced this pull request Jan 27, 2023
Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
vagimeli added a commit that referenced this pull request Jan 30, 2023
@kolchfa-aws kolchfa-aws added the backport 1.3 PR: Backport label for v1.3.x label Mar 16, 2023
@opensearch-trigger-bot
Copy link

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2454-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 894b561b088a2b29910667449e077c58b3dc94fa
# Push it to GitHub
git push --set-upstream origin backport/backport-2454-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2454-to-1.3.

@hdhalter hdhalter deleted the debian-osd-editorial-changes branch March 28, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 1.3 PR: Backport label for v1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add install guide for Debian distribution of OSD
4 participants