Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ML Dashboards page #2987

Merged
merged 11 commits into from
Feb 27, 2023
Merged

Add ML Dashboards page #2987

merged 11 commits into from
Feb 27, 2023

Conversation

Naarcha-AWS
Copy link
Collaborator

Fixes #2240

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS
Add ML Dashboards page
38ea656 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS added release-notes PR: Include this PR in the automated release notes v2.6.0 labels Feb 20, 2023
@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner February 20, 2023 17:19
@Naarcha-AWS Naarcha-AWS added the 2 - In progress Issue/PR: The issue or PR is in progress. label Feb 20, 2023
@Naarcha-AWS
Add experimental ML Dashboard for 2.6
52bcb3e 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS
Slight adjustment to picture order
f56ac61 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress 3 - Tech review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. 4 - Doc review PR: Doc review in progress labels Feb 24, 2023
@Naarcha-AWS Naarcha-AWS self-assigned this Feb 24, 2023
@Naarcha-AWS
Add instructions to enable ML commons
3270972 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Feb 27, 2023
@Naarcha-AWS
Small tweak
2289db1 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
carolxob
carolxob approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@carolxob carolxob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with a few minor suggestions.

Naarcha-AWS and others added 2 commits February 27, 2023 11:58
@Naarcha-AWS @carolxob
Update _ml-commons-plugin/ml-dashboard.md
5118490 
Co-authored-by: Caroline <113052567+carolxob@users.noreply.github.com>
@Naarcha-AWS
Add feedback
eb4c585 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
cwillum
cwillum approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
@Naarcha-AWS
Add additonal feedback
01b0b02 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Feb 27, 2023
natebower
natebower reviewed Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!

_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
_ml-commons-plugin/ml-dashboard.md Outdated Show resolved Hide resolved
@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Feb 27, 2023
Naarcha-AWS and others added 3 commits February 27, 2023 13:00
@Naarcha-AWS @natebower
Update _ml-commons-plugin/ml-dashboard.md
b5e731f 
Co-authored-by: Nathan Bower <nbower@amazon.com>
@Naarcha-AWS
Send fix through
6e13e8b 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS
Add editorial feedback
d9cc081 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS merged commit 77da94d into main Feb 27, 2023
@Naarcha-AWS Naarcha-AWS deleted the ml-dashboards branch February 27, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@ylwu-amzn ylwu-amzn ylwu-amzn left review comments

@carolxob carolxob carolxob approved these changes

@cwillum cwillum cwillum approved these changes

Assignees

@Naarcha-AWS Naarcha-AWS

Labels
experimental release-notes PR: Include this PR in the automated release notes v2.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC]Admin UI for ML Commons [Experimental]
5 participants
@Naarcha-AWS @ylwu-amzn @natebower @cwillum @carolxob