Add mention of knn_vector
#5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every other category explicitly mentions the actual type name in the "Field types and description" column except "k-NN vector" category that was missing the actual type name `knn_vector` Signed-off-by: Ruben Laguna <ruben.laguna@gmail.com>
ecerulm
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki and
natebower
as code owners
kolchfa-aws
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Thanks, @ecerulm! In case the category consists of only one item, this table styles the category without a link and links the actual field type. A small change to ensure consistency.
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Ruben Laguna <ruben.laguna@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 25, 2023
* Add mention of `knn_vector` Every other category explicitly mentions the actual type name in the "Field types and description" column except "k-NN vector" category that was missing the actual type name `knn_vector` Signed-off-by: Ruben Laguna <ruben.laguna@gmail.com> * Update _field-types/supported-field-types/index.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Ruben Laguna <ruben.laguna@gmail.com> --------- Signed-off-by: Ruben Laguna <ruben.laguna@gmail.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> (cherry picked from commit 283f5c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
added a commit
that referenced
this pull request
Dec 25, 2023
* Add mention of `knn_vector` Every other category explicitly mentions the actual type name in the "Field types and description" column except "k-NN vector" category that was missing the actual type name `knn_vector` * Update _field-types/supported-field-types/index.md --------- (cherry picked from commit 283f5c1) Signed-off-by: Ruben Laguna <ruben.laguna@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every other category explicitly mentions the actual type name in the "Field types and description" column except "k-NN vector" category that was missing the actual type name
knn_vectorIssues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.