Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log types section to Security Analytics #6235

Merged
merged 32 commits into from
Apr 4, 2024
Merged

Add log types section to Security Analytics #6235

merged 32 commits into from
Apr 4, 2024

Conversation

Naarcha-AWS
Copy link
Collaborator

Fixes #5145

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@hdhalter hdhalter added backport 2.12 PR: Backport label for 2.12 and removed backport 2.11 PR: Backport label for 2.11 labels Mar 1, 2024
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Mar 5, 2024
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Mar 20, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!

_security-analytics/log-types-reference/ad-ldap.md Outdated Show resolved Hide resolved
_security-analytics/log-types-reference/ad-ldap.md Outdated Show resolved Hide resolved
_security-analytics/log-types-reference/ad-ldap.md Outdated Show resolved Hide resolved
_security-analytics/log-types-reference/ad-ldap.md Outdated Show resolved Hide resolved
_security-analytics/log-types-reference/ad-ldap.md Outdated Show resolved Hide resolved
_security-analytics/sec-analytics-config/log-types.md Outdated Show resolved Hide resolved
_security-analytics/sec-analytics-config/log-types.md Outdated Show resolved Hide resolved



## Log type API
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"APIs" (plural)?

_security-analytics/sec-analytics-config/log-types.md Outdated Show resolved Hide resolved

## Log type API

To perform operations for custom log types using the REST API. For more information, refer to the [Log type APIs]({{site.url}}{{site.baseurl}}/security-analytics/api-tools/log-type-api/) documentation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the first sentence a complete one?

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS
Copy link
Collaborator Author

No rush on this, mind taking another look at this @natebower?

@natebower
Copy link
Collaborator

No rush on this, mind taking another look at this @natebower?

@Naarcha-AWS No need for me to review again in its entirety, but I'm happy to take a look at anything specific you think requires my review.

@Naarcha-AWS Naarcha-AWS requested a review from epugh as a code owner April 2, 2024 12:26
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS Just a few minor changes to the added line at the end. Otherwise, LGTM!

_security-analytics/sec-analytics-config/log-types.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS added backport 2.13 PR: Backport label for 2.13 and removed backport 2.12 PR: Backport label for 2.12 labels Apr 3, 2024
@Naarcha-AWS Naarcha-AWS merged commit 88cde9d into main Apr 4, 2024
5 checks passed
@github-actions github-actions bot deleted the log-types branch April 4, 2024 13:34
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 4, 2024
* Add log types section to Security Analytics

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Rename custom log type page.

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Tweak layout.

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Replace image with callouts

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Fix links, fix structure.

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Fix bugs

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Add Joanne's technical feedback. Link back to detectors.

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Update detectors-config.md

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Update log-types.md

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

---------

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
(cherry picked from commit 88cde9d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS pushed a commit that referenced this pull request Apr 4, 2024
* Add log types section to Security Analytics



* Rename custom log type page.



* Tweak layout.



* Replace image with callouts



* Fix links, fix structure.



* Fix bugs



* Add Joanne's technical feedback. Link back to detectors.



* Apply suggestions from code review



* Apply suggestions from code review



* Apply suggestions from code review




* Apply suggestions from code review




* Apply suggestions from code review




* Apply suggestions from code review




* Apply suggestions from code review




* Apply suggestions from code review




* Apply suggestions from code review




* Apply suggestions from code review




* Update detectors-config.md



* Apply suggestions from code review




* Apply suggestions from code review



* Update log-types.md



* Apply suggestions from code review




---------





(cherry picked from commit 88cde9d)

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress backport 2.13 PR: Backport label for 2.13 security-analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC]: Security Analytics - Update Log Types in Log Type descriptions to include various log sources
5 participants