Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the supported metric types #6754

Merged
merged 6 commits into from
Mar 26, 2024

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented Mar 21, 2024

Description

Updates the _monitoring-your-cluster/metrics/getting-started.md to show case the type of metrics supported.

Issues Resolved
Closes #6694

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
@hdhalter hdhalter added release-notes PR: Include this PR in the automated release notes v2.13.0 4 - Doc review PR: Doc review in progress labels Mar 21, 2024
@hdhalter
Copy link
Contributor

Please check the parent for this topic (parent: Trace Analytics). It's not appearing in the TOC.

@hdhalter
Copy link
Contributor

hdhalter commented Mar 21, 2024

If we want to keep this under Monitoring your cluster category, change the metadata at the top to:

---
layout: default
title: Metrics framework
nav_order: 1
has_children: false
has_toc: false
---

# Metrics framework
(Adds the heading 1 title. Place before the experimental paragraph.)

@Naarcha-AWS Naarcha-AWS self-assigned this Mar 21, 2024
@Gaganjuneja
Copy link
Contributor Author

Please check the parent for this topic (parent: Trace Analytics). It's not appearing in the TOC.

Ideally, it should not be trace analytics.

Gagan Juneja and others added 2 commits March 22, 2024 06:49
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Mar 22, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gaganjuneja @Naarcha-AWS Just a few minor changes. Thanks!

_monitoring-your-cluster/metrics/getting-started.md Outdated Show resolved Hide resolved
_monitoring-your-cluster/metrics/getting-started.md Outdated Show resolved Hide resolved
_monitoring-your-cluster/metrics/getting-started.md Outdated Show resolved Hide resolved
@hdhalter hdhalter changed the title Adds the supported metric types. Add the supported metric types Mar 22, 2024
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 5 - Editorial review PR: Editorial review in progress labels Mar 22, 2024
@Naarcha-AWS Naarcha-AWS merged commit 005886f into opensearch-project:main Mar 26, 2024
3 checks passed
@hdhalter hdhalter removed the 6 - Done but waiting to merge PR: The work is done and ready to merge label Mar 26, 2024
@hdhalter hdhalter added the 3 - Done Issue is done/complete label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Update Metrics Framework documentation
4 participants