Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added troubleshooting instructions for environment set up #6833

Merged

Conversation

GumpacG
Copy link
Contributor

@GumpacG GumpacG commented Apr 2, 2024

Description

Added to the environment setup instructions to help contributors with potential issues.

Issues Resolved

#6800
#6242

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hdhalter
Copy link
Contributor

hdhalter commented Apr 9, 2024

@AMoo-Miki - Can you give this a quick tech review? Thanks!

@AMoo-Miki
Copy link
Collaborator

Thanks.

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Apr 11, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Naarcha-AWS
Copy link
Collaborator

I consolidated the error and resolution steps into one bullet a piece.

GumpacG and others added 4 commits April 12, 2024 10:57
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Copy link
Contributor Author

GumpacG commented Apr 12, 2024

@Naarcha-AWS Thanks! I've updated with your suggestions.

@GumpacG GumpacG requested a review from Naarcha-AWS April 12, 2024 20:36
@Naarcha-AWS Naarcha-AWS merged commit 758bb17 into opensearch-project:main Apr 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants