Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing list notification channels API #6982

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

spapadop
Copy link
Contributor

@spapadop spapadop commented Apr 22, 2024

GET /_plugins/_notifications/channels API is missing from the documentation

Description

Adds the missing documentation for listing notification channels

Issues Resolved

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

GET /_plugins/_notifications/channels API is missing from the documentation

Signed-off-by: Sokratis Papadopoulos <sokratis.papadop@gmail.com>
@hdhalter
Copy link
Contributor

Thank you, @spapadop! I'll get this reviewed asap.

@hdhalter hdhalter added 3 - Tech review PR: Tech review in progress backport 2.13 PR: Backport label for 2.13 labels Apr 23, 2024
Copy link
Contributor

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the content looks accurate. Will leave final decision regarding wording to the documentation team.

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Apr 23, 2024
@Naarcha-AWS Naarcha-AWS merged commit 1c0b037 into opensearch-project:main Apr 23, 2024
8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 23, 2024
GET /_plugins/_notifications/channels API is missing from the documentation

Signed-off-by: Sokratis Papadopoulos <sokratis.papadop@gmail.com>
(cherry picked from commit 1c0b037)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@spapadop spapadop deleted the patch-1 branch April 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.13 PR: Backport label for 2.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants