Adds documentation for tiered caching stats API #7158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
@hdhalter This adds documentation around pieces of the tiered caching feature which were merged in separately from the things covered in Sagar's main doc PR. Would you be able to take a look? |
hdhalter
added
backport 2.14
Will do, @peteralfonsi, but can you please address the style errors? Thanks. |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Naarcha-AWS
requested changes
May 15, 2024
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com>
Co-authored-by: Peter Alfonsi <peter.alfonsi@gmail.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Peter Alfonsi <peter.alfonsi@gmail.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
approved these changes
May 16, 2024
Naarcha-AWS
added
5 - Editorial review
natebower
reviewed
May 16, 2024
There was a problem hiding this comment.
@peteralfonsi @Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!
Naarcha-AWS
reviewed
May 16, 2024
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com>
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 17, 2024
* Adds docs for tiered caching stats API Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Fixed style errors Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: Peter Alfonsi <peter.alfonsi@gmail.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: Peter Alfonsi <peter.alfonsi@gmail.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> * Changed wording Signed-off-by: Peter Alfonsi <petealft@amazon.com> --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit 88d1900) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds documentation for the cache stats API, which was introduced as part of tiered caching. Follows up to cache plugin documentation PR.
Issues Resolved
Followup on #6300.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.