Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close content gap for enabled mapping parameter #8548

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Conversation

vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Oct 16, 2024

Description

Closes content gap for mapping parameters

Issues Resolved

#7115

Version

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@vagimeli vagimeli changed the title Close content gap for enabled mapping parameters Close content gap for enabled mapping parameter Oct 16, 2024
@vagimeli
Copy link
Contributor Author

vagimeli commented Oct 16, 2024

@dhwanilpatel @bharath-techie @mgodwan We're trying to closing content gaps for the enabled mapping parameter. Will one of you provide technical review of the content and example? Thank you.

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress labels Oct 22, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Just one minor change. Thanks!

_field-types/mapping-parameters/enabled.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Copy link
Contributor Author

@vagimeli Just one minor change. Thanks!

@natebower Thanks Nate!

@vagimeli
Copy link
Contributor Author

@vagimeli Just one minor change. Thanks!

@natebower Thanks Nate!

@natebower Will you approve for merging? I'm unable to approve because I opened the PR. Thank you :)

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagimeli vagimeli merged commit 91b0439 into main Oct 23, 2024
7 checks passed
@vagimeli vagimeli deleted the enabled-parameter branch October 23, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants