-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new use cases to ML Inference Search Response Processor #8639
Add new use cases to ML Inference Search Response Processor #8639
Conversation
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
b56fb41
to
2b4c140
Compare
rebased and made the changes, please help review again @ylwu-amzn |
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws @mingshl Please see my changes and let me know if you have any questions. Thanks!
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
_search-plugins/search-pipelines/ml-inference-search-response.md
Outdated
Show resolved
Hide resolved
|
||
Step 0: Host a model | ||
The pre-requisite is a registered text similarity model in OpenSearch. For more information about externally hosted models, see [Connecting to externally hosted models]({{site.url}}{{site.baseurl}}/ml-commons-plugin/remote-models/index/). Here is a sample predict, which requires a text and a text_pair field within inputs field. | ||
You must configure an externally hosted LLM for this use case. For more information about externally hosted models, see [Connecting to externally hosted models]({{site.url}}{{site.baseurl}}/ml-commons-plugin/remote-models/index/). Once you register the LLM, you can use the following request to test it. This request requires providing a `text` and `text_pair` fields within the `inputs` field: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws this rerank use case is using a registered text similarity model not llm model
@@ -390,12 +390,13 @@ The response confirms that the processor has generated text embeddings in the `p | |||
} | |||
``` | |||
|
|||
### Example: GENAI use case | |||
### Example: Externally hosted model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a Externally hosted model example at line 99 already. maybe we should come up with other title? @kolchfa-aws
documentation-website/_search-plugins/search-pipelines/ml-inference-search-response.md
Line 99 in faf070f
### Example: Externally hosted model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mingshl! LGTM
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
…ch-project#8639) * add new use cases Signed-off-by: Mingshi Liu <mingshl@amazon.com> * modify use case using rerank processors and use bulk api Signed-off-by: Mingshi Liu <mingshl@amazon.com> * format change suggested by reviewdog Signed-off-by: Mingshi Liu <mingshl@amazon.com> * fix format Signed-off-by: Mingshi Liu <mingshl@amazon.com> * Doc review Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Change titles Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Reorder examples Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Description
add two use cases to ML Inference Search Response Processor that is supported in 2.18
Version
2.18
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.