Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Document setting allowing size > 0 queries into request cache" #8737

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Revert "Document setting allowing size > 0 queries into request cache" #8737

merged 1 commit into from
Nov 13, 2024

Conversation

kolchfa-aws
Copy link
Collaborator

Reverts #8634 because it is for 2.19 and will be overwritten by #8684

@github-actions GitHub Actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws kolchfa-aws added the backport 2.18 PR: Backport label for 2.18 label Nov 13, 2024
natebower
natebower approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws kolchfa-aws merged commit 239d06f into main Nov 13, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 13, 2024
@github-actions
Revert "Document setting allowing size > 0 queries into request cache (…
e687980 
…#8634)" (#8737)

This reverts commit 274987d.

(cherry picked from commit 239d06f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 13, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
@opensearch-trigger-bot
Revert "Document setting allowing size > 0 queries into request cache (…
404c5a2 
…#8634)" (#8737) (#8738)
@kolchfa-aws kolchfa-aws deleted the revert-8634-add-size-nonzero-setting branch November 21, 2024 22:15
epugh pushed a commit to o19s/documentation-website that referenced this pull request Nov 23, 2024
@kolchfa-aws @epugh
Revert "Document setting allowing size > 0 queries into request cache (…
86e170b 
…opensearch-project#8634)" (opensearch-project#8737)

This reverts commit 274987d.

Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower approved these changes

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
backport 2.18 PR: Backport label for 2.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolchfa-aws @natebower