-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only pluginZip publication of Apache Maven artifacts #226
Conversation
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@owaiskazi19 should fix the publication for |
@reta Thanks for the PR. Not to be a bad news here. Still not able to see artifacts for
|
@owaiskazi19 Please check |
Ah! Yes. Missed that. First time working with a plugin.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @reta
@reta we have spotless for our build files too. Can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @reta for the changes. I'd prefer we hold off on merging until the spotless failure is resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wanted to get an understanding if known what is different in our plugin that needs this since I didn't have context on the changes needed here
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Thanks @owaiskazi19 , fixed! |
@reta looks like we need to add these fields in the POM
|
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Use only pluginZip publication of Apache Maven artifacts Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 76c7065) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-feature/agent_framework feature/agent_framework
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-feature/agent_framework
# Create a new branch
git switch --create backport/backport-226-to-feature/agent_framework
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 76c70652a92344ab74fc157fee4165e4e22bf934
# Push it to GitHub
git push --set-upstream origin backport/backport-226-to-feature/agent_framework
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-feature/agent_framework Then, create a pull request where the |
…ts (#228) Use only pluginZip publication of Apache Maven artifacts (#226) * Use only pluginZip publication of Apache Maven artifacts * Address code review comments * Address code review comments --------- (cherry picked from commit 76c7065) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…project#226) * Use only pluginZip publication of Apache Maven artifacts Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Rename repo name in code files and CI (#182) Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Update actions/setup-java action to v4 (#219) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Use only pluginZip publication of Apache Maven artifacts (#226) * Use only pluginZip publication of Apache Maven artifacts Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Integration test infrastructure set up (#230) * Initial integ test framework modification, sets up integration test cluster and fixes ./gradlew run Signed-off-by: Joshua Palis <jpalis@amazon.com> * spotless Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating DEVELOPER_GUIDE Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.2 (#229) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Update to Gradle 8.5 (#227) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.3 (#252) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Update dependency org.eclipse.platform:org.eclipse.core.runtime to v3.30.0 (#255) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Add setting to limit max workflow steps Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Joshua Palis <jpalis@amazon.com>
* Rename repo name in code files and CI (#182) Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Update actions/setup-java action to v4 (#219) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Use only pluginZip publication of Apache Maven artifacts (#226) * Use only pluginZip publication of Apache Maven artifacts Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Integration test infrastructure set up (#230) * Initial integ test framework modification, sets up integration test cluster and fixes ./gradlew run Signed-off-by: Joshua Palis <jpalis@amazon.com> * spotless Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating DEVELOPER_GUIDE Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.2 (#229) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Update to Gradle 8.5 (#227) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.3 (#252) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Update dependency org.eclipse.platform:org.eclipse.core.runtime to v3.30.0 (#255) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Add setting to limit max workflow steps Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit 7bec6e8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Use only pluginZip publication of Apache Maven artifacts
Issues Resolved
Fixes #186
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.