Add an HttpHost Workflow Step #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
============================================
+ Coverage 72.71% 73.10% +0.38%
- Complexity 639 649 +10
============================================
Files 78 79 +1
Lines 3258 3294 +36
Branches 255 257 +2
============================================
+ Hits 2369 2408 +39
+ Misses 777 773 -4
- Partials 112 113 +1 ☔ View full report in Codecov by Sentry. |
dbwiddis
force-pushed
the
http-host-step
branch
2 times, most recently
from
4ee75ed to
172f47a
Compare
4 tasks
dbwiddis
force-pushed
the
http-host-step
branch
from
172f47a to
f826920
Compare
owaiskazi19
reviewed
Feb 22, 2024
owaiskazi19
reviewed
Feb 22, 2024
src/test/java/org/opensearch/flowframework/model/WorkflowValidatorTests.java
Show resolved
Hide resolved
owaiskazi19
approved these changes
Feb 22, 2024
amitgalitz
reviewed
Feb 22, 2024
amitgalitz
reviewed
Feb 22, 2024
src/main/java/org/opensearch/flowframework/workflow/HttpHostStep.java
Outdated
Show resolved
Hide resolved
amitgalitz
reviewed
Feb 22, 2024
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
force-pushed
the
http-host-step
branch
from
f826920 to
8b2c8fe
Compare
amitgalitz
approved these changes
Feb 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Add an HttpHost Workflow Step Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rebase, add TODOs Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 3923f34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
added a commit
that referenced
this pull request
Feb 24, 2024
* Add an HttpHost Workflow Step (#530) * Add an HttpHost Workflow Step Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rebase, add TODOs Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 3923f34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Use Apache HttpHost class for OpenSearch 2.x Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a WorkflowStep configuring an HttpHost. This is similar to the ToolStep in that it simply reflects a configuration which can be re-used in many follow-on steps.
Issues Resolved
Part of #522
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.