[Backport 2.x] Substitute REST path or body parameters in Workflow Steps #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Include params map in WorkflowRequest when provisioning Signed-off-by: Daniel Widdis <widdis@gmail.com> * Pass params to ProcessNode Signed-off-by: Daniel Widdis <widdis@gmail.com> * Pass params to WorkflowSteps Signed-off-by: Daniel Widdis <widdis@gmail.com> * Substitute params Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add change log Signed-off-by: Daniel Widdis <widdis@gmail.com> * Improve param consuming checks, add coverage Signed-off-by: Daniel Widdis <widdis@gmail.com> * Allow specifying key-value pairs in body Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update title in change log Signed-off-by: Daniel Widdis <widdis@gmail.com> * Refactor param and content map generation to a new method Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 3019fb8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
approved these changes
Feb 22, 2024
amitgalitz
approved these changes
Feb 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #536 +/- ##
============================================
+ Coverage 72.00% 72.80% +0.79%
- Complexity 612 639 +27
============================================
Files 78 78
Lines 3201 3258 +57
Branches 246 255 +9
============================================
+ Hits 2305 2372 +67
+ Misses 783 773 -10
Partials 113 113 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3019fb8 from #525.