-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Create index workflow step #574
Added Create index workflow step #574
Conversation
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
============================================
+ Coverage 72.48% 72.55% +0.06%
- Complexity 657 659 +2
============================================
Files 80 80
Lines 3416 3399 -17
Branches 270 268 -2
============================================
- Hits 2476 2466 -10
+ Misses 822 816 -6
+ Partials 118 117 -1 ☔ View full report in Codecov by Sentry. |
@owaiskazi19 have you tested this create index step to attach a default search pipeline using a pipeline_id from a previous step. This should be part of the settings of the index configuration, just wanted to double check |
+1 |
@joshpalis @amitgalitz I tested with ingest pipeline, but should be the same for search as well. I have pasted the template, response and mapping here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM but see comment.
src/main/java/org/opensearch/flowframework/common/WorkflowResources.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/DeleteIndexStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
* Implemented Create Index Step Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Added DeleteIndex Step and tests Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Added changelog entry Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Removed DeleteIndexStep and tests Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit 1f6573d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Added Create index workflow step (#574) * Implemented Create Index Step * Added DeleteIndex Step and tests * Added changelog entry * Removed DeleteIndexStep and tests --------- (cherry picked from commit 1f6573d) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Request
Response for Create Index Provisioning
Response for Deprovisioning
Issues Resolved
Resolves #103
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.