-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add ApiSpecFetcher for Fetching and Comparing API Specifications #906
Conversation
* Added ApiSpecFetcher with test Signed-off-by: Junwei Dai <junweid@amazon.com> * remove duplication license Signed-off-by: Junwei Dai <junweid@amazon.com> * Add more test to pass test coverage check Signed-off-by: Junwei Dai <junweid@amazon.com> * new commit address all comments Signed-off-by: Junwei Dai <junweid@amazon.com> * new commit address all comments Signed-off-by: Junwei Dai <junweid@amazon.com> * Addressed all comments Signed-off-by: Junwei Dai <junweid@amazon.com> --------- Signed-off-by: Junwei Dai <junweid@amazon.com> Co-authored-by: Junwei Dai <junweid@amazon.com> (cherry picked from commit 57b8b59) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
@dbwiddis the backport should not because of lucene upgrade. As lucene upgrade has happened only for main branch. :D |
@navneet1v yeah, didn't spend long enough looking at the log, saw NoClassDefFoundError and just assumed. Seems we need some more dependencies on the backport, related to slf4j (CC: @junweid62) |
Looks like on
but on 2.x we don't
|
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #906 +/- ##
============================================
+ Coverage 78.04% 78.07% +0.03%
- Complexity 977 995 +18
============================================
Files 97 99 +2
Lines 4554 4621 +67
Branches 423 431 +8
============================================
+ Hits 3554 3608 +54
- Misses 823 833 +10
- Partials 177 180 +3 ☔ View full report in Codecov by Sentry. |
Backport 57b8b59 from #900.