Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Consistency Tests with ML-Common and Set Up Daily GitHub Action Trigger #937

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

junweid62
Copy link
Contributor

@junweid62 junweid62 commented Oct 28, 2024

Description

  1. Modified the compareRequiredFields method in ApiFetcher to use containsAll instead of equal , ensuring that all required fields for our step inputs are included. For example, while registerLocalModel and registerRemoteModel require different input parameters, they both call the same API in ML Common.
  2. Added all the remained Consistency Tests.

Related Issues

Resolves #908
Resolves #651

Issue Related #833

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Junwei Dai added 2 commits October 28, 2024 13:33
Signed-off-by: Junwei Dai <junweid@amazon.com>
Signed-off-by: Junwei Dai <junweid@amazon.com>
Junwei Dai added 3 commits October 28, 2024 13:48
Signed-off-by: Junwei Dai <junweid@amazon.com>
Signed-off-by: Junwei Dai <junweid@amazon.com>
Signed-off-by: Junwei Dai <junweid@amazon.com>
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (980e16d) to head (0c73128).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #937   +/-   ##
=========================================
  Coverage     78.07%   78.07%           
  Complexity      996      996           
=========================================
  Files            99       99           
  Lines          4625     4625           
  Branches        431      431           
=========================================
  Hits           3611     3611           
  Misses          834      834           
  Partials        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junweid62
Copy link
Contributor Author

@dbwiddis Hi Dan, when you have a moment, could you help review my PR? Thanks a lot:)

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two minor suggestions.

Signed-off-by: Junwei Dai <junweid@amazon.com>
@dbwiddis dbwiddis merged commit 50e45ac into opensearch-project:main Nov 1, 2024
20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 1, 2024
…on Trigger (#937)

* Added the rest api spec comparison test

Signed-off-by: Junwei Dai <junweid@amazon.com>

* Added github Action to run api consistency test daily

Signed-off-by: Junwei Dai <junweid@amazon.com>

* fix formating issue

Signed-off-by: Junwei Dai <junweid@amazon.com>

* add change log

Signed-off-by: Junwei Dai <junweid@amazon.com>

* fix *import

Signed-off-by: Junwei Dai <junweid@amazon.com>

* addrssed all comment

Signed-off-by: Junwei Dai <junweid@amazon.com>

---------

Signed-off-by: Junwei Dai <junweid@amazon.com>
Co-authored-by: Junwei Dai <junweid@amazon.com>
(cherry picked from commit 50e45ac)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Nov 1, 2024
…ily GitHub Action Trigger (#942)

Add API Consistency Tests with ML-Common and Set Up Daily GitHub Action Trigger (#937)

* Added the rest api spec comparison test



* Added github Action to run api consistency test daily



* fix formating issue



* add change log



* fix *import



* addrssed all comment



---------



(cherry picked from commit 50e45ac)

Signed-off-by: Junwei Dai <junweid@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Junwei Dai <junweid@amazon.com>
@junweid62 junweid62 deleted the api-test-full branch November 1, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
3 participants