Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Locale.getDefault() with Local.ROOT #214

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Feb 2, 2023

Description

Following same standard as OpenSearch

Issues Resolved

#77

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VijayanB VijayanB requested a review from a team February 2, 2023 18:11
@VijayanB VijayanB self-assigned this Feb 2, 2023
@VijayanB VijayanB added backport 2.x Backport PR to 2.x branch v2.6.0 labels Feb 2, 2023
Following same standard as OpenSearch

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@VijayanB VijayanB merged commit 03ec5c9 into opensearch-project:main Feb 2, 2023
@VijayanB VijayanB deleted the use-root branch February 2, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport PR to 2.x branch Refactoring v2.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants