-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump for spotlss and apache commons #400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
September 5, 2023 17:35
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
=========================================
Coverage 88.59% 88.59%
- Complexity 751 753 +2
=========================================
Files 92 92
Lines 2717 2717
Branches 221 221
=========================================
Hits 2407 2407
- Misses 228 230 +2
+ Partials 82 80 -2 |
heemin32
changed the title
Update spotless from 5.6.1 to 6.21.0
Version bump for spotlss and apache commons
Sep 5, 2023
heemin32
force-pushed
the
spotless
branch
3 times, most recently
from
September 5, 2023 18:01
0201752
to
88d88c6
Compare
@heemin32 whitesource check is failing. Can you please check what is happening. |
Spotless fails in 2.x branch with old version with following error `Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'` Signed-off-by: Heemin Kim <heemin@amazon.com>
spotless 6.21.0-> google-java-format-1.17.0.jar -> guava-31.1-jre.jar (Vulnerable) Switching to spotless 6.3.0, same version that k-NN is using. |
navneet1v
approved these changes
Sep 5, 2023
junqiu-lei
approved these changes
Sep 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
Spotless fails in 2.x branch with old version with following error `Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'` Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit cd3e211)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
Spotless fails in 2.x branch with old version with following error `Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'` Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit cd3e211)
heemin32
added a commit
that referenced
this pull request
Sep 5, 2023
Spotless fails in 2.x branch with old version with following error `Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'` Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit cd3e211) Co-authored-by: Heemin Kim <heemin@amazon.com>
heemin32
added a commit
that referenced
this pull request
Sep 5, 2023
Spotless fails in 2.x branch with old version with following error `Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'` Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit cd3e211) Co-authored-by: Heemin Kim <heemin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spotless fails in 2.x branch with old version with following error
Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.