Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump for spotlss and apache commons #400

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

heemin32
Copy link
Collaborator

@heemin32 heemin32 commented Sep 5, 2023

Description

Spotless fails in 2.x branch with old version with following error Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'

Issues Resolved

N/A

Check List

  • [Z] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #400 (c1f26e9) into main (66c3320) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #400   +/-   ##
=========================================
  Coverage     88.59%   88.59%           
- Complexity      751      753    +2     
=========================================
  Files            92       92           
  Lines          2717     2717           
  Branches        221      221           
=========================================
  Hits           2407     2407           
- Misses          228      230    +2     
+ Partials         82       80    -2     

see 2 files with indirect coverage changes

@heemin32 heemin32 changed the title Update spotless from 5.6.1 to 6.21.0 Version bump for spotlss and apache commons Sep 5, 2023
@heemin32 heemin32 force-pushed the spotless branch 3 times, most recently from 0201752 to 88d88c6 Compare September 5, 2023 18:01
@navneet1v
Copy link
Collaborator

@heemin32 whitesource check is failing. Can you please check what is happening.

Spotless fails in 2.x branch with old version with following error
`Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'`

Signed-off-by: Heemin Kim <heemin@amazon.com>
@heemin32
Copy link
Collaborator Author

heemin32 commented Sep 5, 2023

@heemin32 whitesource check is failing. Can you please check what is happening.

spotless 6.21.0-> google-java-format-1.17.0.jar -> guava-31.1-jre.jar (Vulnerable)

Switching to spotless 6.3.0, same version that k-NN is using.

@heemin32 heemin32 added the backport 2.10 Backport to 2.10 branch label Sep 5, 2023
@heemin32 heemin32 merged commit cd3e211 into opensearch-project:main Sep 5, 2023
15 checks passed
@heemin32 heemin32 deleted the spotless branch September 5, 2023 18:35
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2023
Spotless fails in 2.x branch with old version with following error
`Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'`

Signed-off-by: Heemin Kim <heemin@amazon.com>
(cherry picked from commit cd3e211)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2023
Spotless fails in 2.x branch with old version with following error
`Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'`

Signed-off-by: Heemin Kim <heemin@amazon.com>
(cherry picked from commit cd3e211)
heemin32 added a commit that referenced this pull request Sep 5, 2023
Spotless fails in 2.x branch with old version with following error
`Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'`

Signed-off-by: Heemin Kim <heemin@amazon.com>
(cherry picked from commit cd3e211)

Co-authored-by: Heemin Kim <heemin@amazon.com>
heemin32 added a commit that referenced this pull request Sep 5, 2023
Spotless fails in 2.x branch with old version with following error
`Caused by: java.lang.NoSuchMethodError: 'long com.sun.tools.javac.tree.DCTree$DCReference.getSourcePosition(com.sun.tools.javac.tree.DCTree$DCDocComment)'`

Signed-off-by: Heemin Kim <heemin@amazon.com>
(cherry picked from commit cd3e211)

Co-authored-by: Heemin Kim <heemin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport PR to 2.x branch backport 2.10 Backport to 2.10 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants