Adding MDS support in Notifications page in ISM #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramakrishna Chilaka <ramachil@amazon.com>
RamakrishnaChilaka
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
CaptainDredge
approved these changes
Aug 17, 2024
1 task
SuZhou-Joe
approved these changes
Aug 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Signed-off-by: Ramakrishna Chilaka <ramachil@amazon.com> (cherry picked from commit 018b831) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
skumawat2025
pushed a commit
to skumawat2025/index-management-dashboards-plugin
that referenced
this pull request
Aug 19, 2024
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 19, 2024
Signed-off-by: Ramakrishna Chilaka <ramachil@amazon.com> (cherry picked from commit 018b831) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 018b831) Signed-off-by: Ramakrishna Chilaka <ramachil@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds multi data source selector (described in opensearch-project/OpenSearch-Dashboards#6035). This change adds MDS support to Notification page in ISM.
Issues Resolved
#982 This issue will be solved partially through this PR.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.