Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fit and Finish] Replaced EuiText with EuiTitle for section headers in content areas #1182

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[Fit and Finish] Replaced EuiText with EuiTitle for section headers in content areas #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/components/ChannelNotification/ChannelNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const ChannelNotification = ({
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiSmallButton iconType="popout" href="notifications-dashboards#/channels" target="_blank">
<EuiSmallButton iconType="popout" href="notifications-dashboards#/channels" target="_blank" iconSide="right">
Manage channels
</EuiSmallButton>
</EuiFlexItem>
Expand Down
2 changes: 1 addition & 1 deletion public/components/ChannelNotification/__snapshots__/ChannelNotification.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ exports[`<ChannelNotification /> spec renders the component 1`] = `
target="_blank"
>
<span
class="euiButtonContent euiButton__content"
class="euiButtonContent euiButtonContent--iconRight euiButton__content"
>
EuiIconMock
<span
Expand Down
18 changes: 8 additions & 10 deletions public/components/IndexDetail/IndexDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,10 +457,9 @@ const IndexDetail = (
return (
<>
<EuiPanel>
<EuiText size="s">
{" "}
<h2>{title}</h2>{" "}
</EuiText>
<EuiTitle size="s">
<h2>{title}</h2>
</EuiTitle>
<EuiHorizontalRule margin="xs" />
{content}
</EuiPanel>
Expand Down Expand Up @@ -581,10 +580,9 @@ const IndexDetail = (
return (
<>
<EuiPanel>
<EuiText size="s">
{" "}
<h2>Index settings</h2>{" "}
</EuiText>
<EuiTitle size="s">
<h2>Index settings</h2>
</EuiTitle>
<EuiHorizontalRule margin="xs" />
{content}
</EuiPanel>
Expand Down Expand Up @@ -628,12 +626,12 @@ const IndexDetail = (

return (
<EuiPanel>
<EuiText size="s">
<EuiTitle size="s">
<h2>
Index mapping
<OptionalLabel />
</h2>
</EuiText>
</EuiTitle>
<EuiCompressedFormRow
fullWidth
helpText={
Expand Down
12 changes: 4 additions & 8 deletions public/components/IndexDetail/__snapshots__/IndexDetail.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,11 @@ exports[`<IndexDetail /> spec renders the component 1`] = `
<div
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiText euiText--small"
<h2
class="euiTitle euiTitle--small"
>

<h2>
Define index
</h2>

</div>
Define index
</h2>
<hr
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
Expand Down
2 changes: 1 addition & 1 deletion public/containers/ErrorNotification/__snapshots__/ErrorNotification.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ exports[`<ErrorNotification /> spec renders the component 1`] = `
target="_blank"
>
<span
class="euiButtonContent euiButton__content"
class="euiButtonContent euiButtonContent--iconRight euiButton__content"
>
EuiIconMock
<span
Expand Down
10 changes: 4 additions & 6 deletions public/containers/IndexDetail/__snapshots__/IndexDetail.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@ exports[`<IndexDetail /> spec render the component 1`] = `
<div
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiText euiText--small"
<h2
class="euiTitle euiTitle--small"
>
<h2>
Source index details
</h2>
</div>
Source index details
</h2>
<hr
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
Expand Down
4 changes: 2 additions & 2 deletions public/containers/IndexDetail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ export default function IndexDetail(props: IIndexDetailProps) {
}, [props.indices.join(","), setLoading, setItems, coreServices]);
return (
<EuiPanel>
<EuiText size="s">
<EuiTitle size="s">
<h2>Source index details</h2>
</EuiText>
</EuiTitle>
<EuiHorizontalRule margin="xs" />
<EuiSpacer size="s" />
{items && items.length ? (
Expand Down
40 changes: 15 additions & 25 deletions public/containers/IndexForm/__snapshots__/IndexForm.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,11 @@ exports[`<IndexForm /> spec render page 1`] = `
<div
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiText euiText--small"
<h2
class="euiTitle euiTitle--small"
>

<h2>
Define index
</h2>

</div>
Define index
</h2>
<hr
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
Expand Down Expand Up @@ -183,15 +179,11 @@ exports[`<IndexForm /> spec render page 1`] = `
<div
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiText euiText--small"
<h2
class="euiTitle euiTitle--small"
>

<h2>
Index settings
</h2>

</div>
Index settings
</h2>
<hr
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
Expand Down Expand Up @@ -593,16 +585,14 @@ exports[`<IndexForm /> spec render page 1`] = `
<div
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiText euiText--small"
<h2
class="euiTitle euiTitle--small"
>
<h2>
Index mapping
<i>
– optional
</i>
</h2>
</div>
Index mapping
<i>
– optional
</i>
</h2>
<div
class="euiFormRow euiFormRow--fullWidth euiFormRow--compressed"
id="some_html_id-row"
Expand Down
6 changes: 5 additions & 1 deletion public/containers/NotificationConfig/NotificationConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,11 @@ const NotificationConfig = (
/>
</EuiFlexItem>
<EuiFlexItem>
<EuiSmallButton onClick={() => window.open("/app/notifications-dashboards#/channels")} iconType="popout">
<EuiSmallButton
onClick={() => window.open("/app/notifications-dashboards#/channels")}
iconType="popout"
iconSide="right"
>
Manage channels
</EuiSmallButton>
</EuiFlexItem>
Expand Down
6 changes: 3 additions & 3 deletions public/pages/ChangePolicy/components/ChangeManagedIndices/ChangeManagedIndices.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

import React, { Component } from "react";
import { EuiSpacer, EuiCompressedComboBox, EuiCompressedFormRow, EuiText, EuiHorizontalRule, EuiPanel } from "@elastic/eui";
import { EuiSpacer, EuiCompressedComboBox, EuiCompressedFormRow, EuiText, EuiHorizontalRule, EuiPanel, EuiTitle } from "@elastic/eui";
import { ContentPanel } from "../../../../components/ContentPanel";
import { ManagedIndexService } from "../../../../services";
import { ManagedIndexItem, State } from "../../../../../models/interfaces";
Expand Down Expand Up @@ -90,9 +90,9 @@ export default class ChangeManagedIndices extends Component<ChangeManagedIndices

return (
<EuiPanel>
<EuiText size="s">
<EuiTitle size="s">
<h2>Choose managed indices</h2>
</EuiText>
</EuiTitle>
<EuiHorizontalRule margin="xs" />
<div>
<EuiCompressedFormRow
Expand Down
10 changes: 4 additions & 6 deletions ...gePolicy/components/ChangeManagedIndices/__snapshots__/ChangeManagedIndices.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@ exports[`<ChangeManagedIndices /> spec renders the component 1`] = `
<div
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiText euiText--small"
<h2
class="euiTitle euiTitle--small"
>
<h2>
Choose managed indices
</h2>
</div>
Choose managed indices
</h2>
<hr
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
Expand Down
5 changes: 3 additions & 2 deletions public/pages/ChangePolicy/components/NewPolicy/NewPolicy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
EuiIcon,
EuiPanel,
EuiHorizontalRule,
EuiTitle,
} from "@elastic/eui";
import { ContentPanel } from "../../../../components/ContentPanel";
import { IndexService } from "../../../../services";
Expand Down Expand Up @@ -111,9 +112,9 @@ export default class NewPolicy extends React.Component<NewPolicyProps, NewPolicy
const radioOptions = [currentRadio, stateRadio];
return (
<EuiPanel>
<EuiText size="s">
<EuiTitle size="s">
<h2>Choose new policy</h2>
</EuiText>
</EuiTitle>
<EuiHorizontalRule margin="xs" />
<div>
<EuiText size="xs">
Expand Down
10 changes: 4 additions & 6 deletions public/pages/ChangePolicy/components/NewPolicy/__snapshots__/NewPolicy.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@ exports[`<NewPolicy /> spec renders the component 1`] = `
<div
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiText euiText--small"
<h2
class="euiTitle euiTitle--small"
>
<h2>
Choose new policy
</h2>
</div>
Choose new policy
</h2>
<hr
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
Expand Down
20 changes: 8 additions & 12 deletions public/pages/ChangePolicy/containers/ChangePolicy/__snapshots__/ChangePolicy.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,11 @@ exports[`<ChangePolicy /> spec renders the component 1`] = `
<div
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiText euiText--small"
<h2
class="euiTitle euiTitle--small"
>
<h2>
Choose managed indices
</h2>
</div>
Choose managed indices
</h2>
<hr
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
Expand Down Expand Up @@ -206,13 +204,11 @@ exports[`<ChangePolicy /> spec renders the component 1`] = `
<div
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiText euiText--small"
<h2
class="euiTitle euiTitle--small"
>
<h2>
Choose new policy
</h2>
</div>
Choose new policy
</h2>
<hr
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
Expand Down
8 changes: 3 additions & 5 deletions public/pages/CreateComposableTemplate/components/IndexSettings/IndexSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,9 @@ export default function IndexSettings(props: SubDetailProps) {
<ContentPanel
color={noPanel ? "ghost" : undefined}
title={
<EuiText size="s">
<EuiTitle>
<h2>Index settings</h2>
</EuiTitle>
</EuiText>
<EuiTitle size="s">
<h2>Index settings</h2>
</EuiTitle>
}
noExtraPadding
actions={
Expand Down
Loading
Loading