Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting validation for transform APIs #1191

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

tandonks
Copy link
Contributor

@tandonks tandonks commented Oct 21, 2024

Description

Setting validation for couple of transform APIs

  • /api/ism/transforms/_preview: Have added validations to ensure that body parameter are of a specific type only and also the indexes names and datasourceId should have a specifed range of length and should consist of some particular characters only

  • /api/ism/_searchSampleData/{index}: Similarly have added validations for datasourceId and index name

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (a53ff41) to head (29a3cee).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
- Coverage   61.61%   60.96%   -0.65%     
==========================================
  Files         345      347       +2     
  Lines       12449    12831     +382     
  Branches     2509     2588      +79     
==========================================
+ Hits         7671     7823     +152     
- Misses       4075     4269     +194     
- Partials      703      739      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit fd0e765 into opensearch-project:main Oct 28, 2024
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2024
* Enabling validation for transform APIs

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Updating snap files

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Reverting some of the updated snap files from previous commit

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Reverting some changes to test workflows

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Change workflows java version to 21 from 11

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Reverting some changes done just to test the workflows

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Updating vaidation rules and tests

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing an issue with API validation

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
(cherry picked from commit fd0e765)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2024
* Enabling validation for transform APIs

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Updating snap files

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Reverting some of the updated snap files from previous commit

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Reverting some changes to test workflows

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Change workflows java version to 21 from 11

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Reverting some changes done just to test the workflows

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Updating vaidation rules and tests

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing an issue with API validation

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
(cherry picked from commit fd0e765)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe added a commit that referenced this pull request Oct 28, 2024
* Setting validation for transform APIs (#1191)

* Enabling validation for transform APIs

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Updating snap files

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Reverting some of the updated snap files from previous commit

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Reverting some changes to test workflows

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Change workflows java version to 21 from 11

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Reverting some changes done just to test the workflows

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Updating vaidation rules and tests

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing an issue with API validation

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
(cherry picked from commit fd0e765)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: use fixed version

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Oct 28, 2024
* Enabling validation for transform APIs



* Updating snap files



* Reverting some of the updated snap files from previous commit



* Reverting some changes to test workflows



* Change workflows java version to 21 from 11



* Reverting some changes done just to test the workflows



* Updating vaidation rules and tests



* Fixing an issue with API validation



---------


(cherry picked from commit fd0e765)

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants