Explain response still use old opendistro policy id #109
+65
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
bowenlan-amzn
force-pushed
the
policyid
branch
2 times, most recently
from
14dc0e1 to
dbe1b4b
Compare
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
============================================
+ Coverage 78.14% 78.16% +0.01%
+ Complexity 1893 1889 -4
============================================
Files 255 255
Lines 10470 10461 -9
Branches 1548 1546 -2
============================================
- Hits 8182 8177 -5
+ Misses 1434 1431 -3
+ Partials 854 853 -1
Continue to review full report at Codecov.
|
dbbaughe
approved these changes
Aug 3, 2021
dbbaughe
pushed a commit
to dbbaughe/index-management-1
that referenced
this pull request
Aug 25, 2021
…ct#109) * Explain response still use old opendistro policy id * Use hardcoded policyid setting in tests for explain response * Trying to fix flaky tests
dbbaughe
added a commit
that referenced
this pull request
Aug 25, 2021
* Explain response still use old opendistro policy id (#109) * Explain response still use old opendistro policy id * Use hardcoded policyid setting in tests for explain response * Trying to fix flaky tests * Release notes for 1.0.0.0 (#96) * Updates build.gradle/github workflows, version, and adds release notes Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>
thalurur
pushed a commit
to thalurur/open-index-management
that referenced
this pull request
Oct 22, 2021
* Rename plugin helper file * Update TransformIndices.tsx * Backport commits from main (opensearch-project#90) * Release 1.1.0.0 (opensearch-project#83) * Release 1.1.0.0 Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Correct copyright notices * UI fixes for new ISM UI (opensearch-project#84) * Removes X icon from action/transition flyout footer next to cancel Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds tooltips to edit/delete icon buttons on the draggable action/transition components Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Removes overlay for flyout so clicking outside doesn't close flyout and removes X close button on top right Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds edit/delete tooltips for state component and removes underline from hovering states Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Changes state flyout from X Close to Cancel Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds JSON editor for allocation action Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds isValid to action interface and implements in actions Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Correctly removes unused rollover keys from rollover object, handles uncontrolled inputs and NaN minDocs Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds error for state name already existing in policy Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes duplicated actions when editing as previously we had a new ID and matching logic didn't find an action Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes other action inputs that can return NaN and creates a no conditions option that is the default Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates snapshot Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Correctly show danger toast on update/create failures Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes rollup action nesting multiple ism_template keys Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes timeout/retry settings turning into uncontrolled inputs and NaN value Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Removes text transformation on inputs and updates isValid methods and passes to form labels Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes allocation and rollup adding UIAction properties to policy JSON on updates Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates release notes w/ new PR changes Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Wraps actions/transitions in states component and updates default rollup to include ism_rollup key Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes some small UI touchups/issues for new ISM UI (opensearch-project#85) * Moves cancel secondary button next to primary on action/transition flyout Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Removes default ISM template and increases width of empty prompt Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds punctuation Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds back X icon next to cancel for state flyout Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Makes inputs in flyout full width, updates help text, and adds some spacing Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates transition default to not include conditions empty object, and on change transition to delete conditions when selecting none Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Moves edit button out of policy settings content panel and on to global page for view policy Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates release note Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes broken link Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes small issues on new ISM UI (opensearch-project#88) * Fixes small issues on new ISM UI Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates snapshots Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates release notes Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates workflows to trigger on 1.* branches Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com> * Support data filter when viewing sample data * Update TransformOptions.tsx * Add TransformService.test.ts * Draft of date histogram panel * Add helper method and move import * Split calendar and fixed interval to 2 panels * Add rendering test * Add close popover test * Update cypress-workflow.yml * Update links.yml * Update unit-tests-workflow.yml * Update TransformOptions.tsx * Update tests * Update DateHistogramPanel.test.tsx * Make scripted metrics editor larger * Expand code editor related panels * Undo changes to workflow Signed-off-by: Annie Lee <leeyun@amazon.com> * Update TimeAggregation.tsx * Update DefineTransforms.tsx undo changes to style * Clean up code * Update snapshot Signed-off-by: Annie Lee <leeyun@amazon.com> * Refactor the order of checking if name is defined before checking for duplicate name * Update CreateTransformForm.tsx * Update DefineTransforms.tsx Signed-off-by: Annie Lee <leeyun@amazon.com> * Update DefineTransforms.tsx Signed-off-by: Annie Lee <leeyun@amazon.com> * Update DefineTransforms.tsx * Update DefineTransforms.tsx * Update DefineTransforms.tsx Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>
downsrob
added a commit
that referenced
this pull request
Nov 5, 2021
* Add integTest script to the repo (#94) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Removing Usages of Action Get Call and using listeners (#100) Signed-off-by: Aditya Jindal <aditjind@amazon.com> * Enhance ISM template (#105) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Explain response still use old opendistro policy id (#109) * Explain response still use old opendistro policy id * Use hardcoded policyid setting in tests for explain response * Trying to fix flaky tests * Storing user information as part of the job when security plugin is installed (#113) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * ISM/Notification channel support (#117) * Updates NAME of transport actions * Upgrades Kotlin version, updates dependencies on other OS plugins, adds notification plugin as a test resource and includes it in test clusters * Adds support for Channels in error notifications and notification actions * Adds support for sending notifications to channels * Adds support for publishing notifications to the legacy destinations through the Notification plugin and some cleanup * Removes notification alerting jar dependency * Adds compile only dep on commons codec for digest utils sha1 method in ism rollup * Updates Error Notification to make channel/destination nullable, and adds helper methods for publish calls * Constructs URL for legacy custom webhook Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes Feature enum and dep Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Trying something else Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Addresses comments Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Storing user object in all APIs and enabling filter of response based on user (#115) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * Upgrade dependencies to 1.1 and build snapshot by default. (#121) Signed-off-by: dblock <dblock@amazon.com> * Security improvements (#126) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * Removes support for notification plugin (#136) Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updating security filtering logic (#137) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * Release note for 1.1.0.0 release. (#139) * Release note for 1.1.0.0 release. Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Correct copyright notices * Uses published daily snapshot dependencies (#141) Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * License header check (#142) * Provide default copyright header using IDE feature Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Address #103 history write index is rolled over even if the history indices are disabled * Removed integtest.sh. (#148) Signed-off-by: dblock <dblock@dblock.org> * Adds mavenLocal back to repositories (#158) Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Making snapshot name to scripted input in template (#77) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * Fix issues with security changes in rollup runnner (#161) * Updates index management version to 1.2 (#157) * Updates index management version to 1.2 * Updates job scheduler snapshot to 1.2 in test resources Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds setting to search all rollup jobs on a target index (#165) * Adds cluster setting to search all rollup jobs Signed-off-by: Clay Downs <downsrob@amazon.com> * Adds implementation for the delay feature in rollup jobs (#147) * Adds delay implementation for rollup jobs * Removes non-continuous delay implementation * Adds additional rollup delay tests Signed-off-by: Clay Downs <downsrob@amazon.com> * Updates testCompile mockito version, adds AwaitsFix annotation to MetadataRegressionIT tests (#168) * Updates testCompile mockito version to match OpenSearch changes * AwaitsFix on the failing MetadataRegressionIT tests Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds cluster setting to configure index state management jitter (#153) * Adds jitter cluster setting, sets jitter to 0 for ISM tests Signed-off-by: Clay Downs <downsrob@amazon.com> * Allows out of band rollovers on an index without causing ISM to fail (#180) * Allows out of band rollovers on an index without causing ISM to fail Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes detekt issue Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Remove policy API on read only indices (#182) * In explain API not showing the total count to all users (#185) Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Aditya Jindal <13850971+aditjind@users.noreply.github.com> Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com> Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
…ct#109) * Explain response still use old opendistro policy id * Use hardcoded policyid setting in tests for explain response * Trying to fix flaky tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bowenlan-amzn bowenlan23@gmail.com
Issue #, if available:
#108
Description of changes:
For this flaky test part link
Seems
copyis a shallow copy here, and this assert directly pass.CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.