Fixes test failures with security enabled #292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Downs downsrob@amazon.com
Issue #, if available:
NA
Description of changes:
Index management tests with security enabled were failing due to a mismatch in the default explain indices response between when security is enabled or disabled. When security was disabled and the index did not exist, the enabledStatus would be null. When security was enabled, the enabled status would default to false due to this code which runs during security filtering:
index-management/src/main/kotlin/org/opensearch/indexmanagement/indexstatemanagement/transport/action/explain/TransportExplainAction.kt
Line 347 in e9351ce
This line was added in this PR #126 over 6 months ago, so it is strange that these failures haven't surfaced before this, as the behavior should have been the same when testing with security any time since.
The following tests were failing persistently with security enabled before this change:
After making this change, assembling the plugin and installing it in the previous used test cluster, the tests pass.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.