Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Forum link in Index Management plugin README.md #499

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Sep 7, 2022

Signed-off-by: cwillum cwmmoore@amazon.com

Description of changes:
Replaced the link to the Forum discussion in the README.md file so that it points to the OpenSearch forum rather than the defunct Open Distro forum.
Also replaced documentation link with link that goes directly to Index Management.

CheckList:
This fixes the issue for the Index Management plugin in #921.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: cwillum <cwmmoore@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #499 (8e26d65) into main (39be4e3) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #499      +/-   ##
============================================
- Coverage     75.94%   75.83%   -0.12%     
+ Complexity     2480     2472       -8     
============================================
  Files           315      315              
  Lines         14500    14500              
  Branches       2243     2243              
============================================
- Hits          11012    10996      -16     
- Misses         2239     2253      +14     
- Partials       1249     1251       +2     
Impacted Files Coverage Δ
...nt/indexstatemanagement/model/destination/Slack.kt 55.55% <0.00%> (-22.23%) ⬇️
...ent/rollup/action/explain/ExplainRollupResponse.kt 76.19% <0.00%> (-9.53%) ⬇️
...arch/indexmanagement/rollup/RollupSearchService.kt 57.40% <0.00%> (-3.71%) ⬇️
...gement/indexstatemanagement/action/ShrinkAction.kt 69.11% <0.00%> (-2.95%) ⬇️
...ndexstatemanagement/IndexStateManagementHistory.kt 78.62% <0.00%> (-1.38%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 84.61% <0.00%> (-1.29%) ⬇️
...earch/indexmanagement/transform/TransformRunner.kt 78.31% <0.00%> (-0.61%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 68.71% <0.00%> (-0.59%) ⬇️
.../action/explain/TransportExplainTransformAction.kt 73.03% <0.00%> (+2.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwillum
Copy link
Contributor Author

cwillum commented Sep 8, 2022

@opensearch-project/index-management Anyone available to assist in resolving this Test and Build Workflow failure, and possibly a review? I made some brief edits to the README.md file to provide links to the Forum. Nothing more. Thanks.

@cwillum
Copy link
Contributor Author

cwillum commented Sep 9, 2022

@opensearch-project/index-management Thanks for the two reviews. And sorry to break the Test and Build Workflow check. Once that is resolved, could someone merge this PR? I don't have that permission in this repo. Thanks.

@bowenlan-amzn
Copy link
Member

@opensearch-project/index-management Thanks for the two reviews. And sorry to break the Test and Build Workflow check. Once that is resolved, could someone merge this PR? I don't have that permission in this repo. Thanks.

@cwillum you didn't break the test. It's a flaky test. We will record it, thanks for the change!

@bowenlan-amzn bowenlan-amzn merged commit 79214a2 into opensearch-project:main Sep 9, 2022
@cwillum
Copy link
Contributor Author

cwillum commented Sep 12, 2022

@bowenlan-amzn Thanks for the merge.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2022
Signed-off-by: cwillum <cwmmoore@amazon.com>

Signed-off-by: cwillum <cwmmoore@amazon.com>
(cherry picked from commit 79214a2)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2022
Signed-off-by: cwillum <cwmmoore@amazon.com>

Signed-off-by: cwillum <cwmmoore@amazon.com>
(cherry picked from commit 79214a2)
Angie-Zhang added a commit that referenced this pull request Oct 14, 2022
* initial framework

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>

* enabled by default integrated

Signed-off-by: Joanne Wang <jowg@amazon.com>

* cleaned up comments and logs, created unit test and updated previous integration tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added delete validation logic

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed rollover validation unit tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation info field to ManagedIndexMetaData

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step context as input

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validationmetadata class

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old integration tests and changed validation service output

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before integrated validation meta data into managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integrated validation meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* working version

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation mapping

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed integ tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* renamed some values

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* created validation result object in explain

Signed-off-by: Joanne Wang <jowg@amazon.com>

* testing

Signed-off-by: Joanne Wang <jowg@amazon.com>

* run fails

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integration test for delete + added framework for force merge

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step validation metadata and still testing explain results

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up and tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* all validation tests pass

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed validation result from all managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old IT tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed it tests, set explain validation to false

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Change test page size to avoid index/search TimeInMillis < 1 issue. (#460)

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Transform maxclauses fix (#477)

* transform maxClauses fix

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* added bucket log to track processed buckets

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* various renames/changes

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed detekt issues

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* added comments to test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* removed debug logging

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* empty commit to trigger checks

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reduced pageSize to 1 in few ITs to avoid flaky tests; fixed bug where pagesProcessed was calculated incorrectly

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted pagesProcessed change; fixed few ITs

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* 483: Updated detekt plugin and snakeyaml dependency. Updated a code t… (#485)

* 483: Updated detekt plugin and snakeyaml dependency. Updated a code to reduce the number of issues after static analysis

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* 483: Updated snakeyaml version to use the latest

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Remove HOST_DENY_LIST usage as Notification plugin will own it (#471)

(#107)

Signed-off-by: Xuesong Luo <lxuesong@amazon.com>

Signed-off-by: Xuesong Luo <lxuesong@amazon.com>

* Disable detekt because of the CVE (#497)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Deprecate Master nonmenclature (#501)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* [AUTO] Increment version to 2.3.0-SNAPSHOT (#484) (#503)

* fix#921-README-forum-link-index_mgmnt (#499)

Signed-off-by: cwillum <cwmmoore@amazon.com>

Signed-off-by: cwillum <cwmmoore@amazon.com>

* 64: Added rounding when using aggreagate script for avg metric. Added… (#490)

* 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* 64: Rollup job renamed

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* 64: Removed unrelevant metrics for the avg calculation test

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Revert Disable detekt and force choose snakeyml 1.32 (#528)

* Revert Disable detekt: 50ac1e9

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Remove force choosing snakeyml 1.31

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Force snakeyaml 1.32

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Empty commit

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Added 2.3 release note (#507) (#515) (#517)

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>
(cherry picked from commit d9793ac)
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>
(cherry picked from commit 7217b5b)

Co-authored-by: Angie Zhang <langelzh@amazon.com>

* Add 2.2 release note (#450) (#452) (#516)

* Add 2.2 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Add 2.2 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Co-authored-by: Angie Zhang <langelzh@amazon.com>
(cherry picked from commit 8eb5da6)
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>

* Adds plugin version sweep background job (#434)

* [207]: Added 5 min scheduled job for sweeping ISM plugin version in the case of version discrepancy

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* [207]: Created pluginVersionSweepCoordinator component responsible for scheduling the skip execution task. Annotated tests in order to prevent thread leak error during integrational tests

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* [207]: Increased retry period for background job that sets the skip flag up to 5 mins

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Empty-Commit

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Co-authored-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* flaky transform test fix attempt (#542)

* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Xuesong Luo <lxuesong@amazon.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Angie Zhang <98716549+Angie-Zhang@users.noreply.github.com>
Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
Co-authored-by: xluo-aws <109580118+xluo-aws@users.noreply.github.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Co-authored-by: Siddhant Deshmukh <deshsid@amazon.com>
Co-authored-by: Angie Zhang <langelzh@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Clay Downs <downsrob@amazon.com>
Co-authored-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants