Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snakeyaml to version 2.0 #818

Conversation

rishabhmaurya
Copy link
Contributor

Snakeyaml released the version 2.0 which also addresses the GHSA-mjmj-j48q-9wg2.

Description of changes:
Similar to opensearch-project/OpenSearch#5576
CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
@getsaurabh02
Copy link
Member

Should we raise this PR against 1.x and backport to 1.3 instead?

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #818 (02810de) into 1.3 (f9e9c6b) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #818      +/-   ##
============================================
- Coverage     77.00%   76.65%   -0.36%     
+ Complexity     2084     2070      -14     
============================================
  Files           254      254              
  Lines         11770    11770              
  Branches       1830     1830              
============================================
- Hits           9064     9022      -42     
- Misses         1691     1755      +64     
+ Partials       1015      993      -22     

see 13 files with indirect coverage changes

@rishabhmaurya
Copy link
Contributor Author

The failure can be ignored as it seem to be flaky test. There was an effort to fix this flaky test in 2.x and its backport to 1.x failed earlier -
#542

Assertion failure -

Suite: Test class org.opensearch.indexmanagement.transform.TransformRunnerIT
  2> REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.indexmanagement.transform.TransformRunnerIT.test continuous transform with wildcard indices" -Dtests.seed=566DD28B92044ABE -Dtests.security.manager=false -Dtests.locale=de-CH -Dtests.timezone=Asia/Beirut -Druntime.java=8
  2> java.lang.AssertionError: Not the expected pages processed expected:<6> but was:<2>
        at __randomizedtesting.SeedInfo.seed([566DD28B92044ABE:BC0B1C1C27D4D359]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.opensearch.indexmanagement.transform.TransformRunnerIT.test continuous transform with wildcard indices(TransformRunnerIT.kt:743)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants