Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LRON concurrent indexing throw ResourceAlreadyExists #831

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

zhichao-aws
Copy link
Member

@zhichao-aws zhichao-aws commented Jun 28, 2023

Issue #, if available:
#823
Description of changes:

  • unwrap the exception to analysis the cause
  • add an IT, modify some IT
    CheckList:
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zhichao-aws
Copy link
Member Author

this PR contains some changes of #825 and #830 . Need to merge those at first

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
@zhichao-aws
Copy link
Member Author

Two PRs mentioned above are merged. rebase main

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #831 (302fd18) into main (bdc9dad) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #831      +/-   ##
============================================
- Coverage     75.85%   75.57%   -0.28%     
+ Complexity     2850     2829      -21     
============================================
  Files           364      364              
  Lines         16176    16176              
  Branches       2325     2325              
============================================
- Hits          12270    12225      -45     
- Misses         2567     2608      +41     
- Partials       1339     1343       +4     
Impacted Files Coverage Δ
...controlcenter/notification/ControlCenterIndices.kt 92.85% <0.00%> (+17.85%) ⬆️

... and 14 files with indirect coverage changes

@Hailong-am Hailong-am merged commit f07fa2b into opensearch-project:main Jul 3, 2023
13 of 15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 3, 2023
* fix LRON unwrap exception and some IT

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* remove useless log

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

---------

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit f07fa2b)
@Hailong-am Hailong-am added the v2.9.0 v2.9.0 label Jul 3, 2023
Hailong-am pushed a commit that referenced this pull request Jul 3, 2023
* fix LRON unwrap exception and some IT

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* remove useless log

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

---------

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit f07fa2b)

Co-authored-by: zhichao-aws <zhichaog@amazon.com>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
…project#831) (opensearch-project#842)

* fix LRON unwrap exception and some IT

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* remove useless log

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

---------

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit f07fa2b)

Co-authored-by: zhichao-aws <zhichaog@amazon.com>
Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants