Remove onetime notification settings when index operation finish #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
amsiglan,
sbcd90,
eirsep and
AWSHurneyt
as code owners
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
force-pushed
the
bug/remove_onetime_notificaiton_setting
branch
from
a282704
to
eb7fb29
Compare
Codecov Report
@@ Coverage Diff @@
## main #839 +/- ##
============================================
+ Coverage 75.85% 75.87% +0.02%
- Complexity 2850 2854 +4
============================================
Files 364 364
Lines 16176 16178 +2
Branches 2325 2327 +2
============================================
+ Hits 12270 12275 +5
+ Misses 2567 2563 -4
- Partials 1339 1340 +1
|
Hailong-am
changed the title
gaobinlong
approved these changes
Jul 3, 2023
xluo-aws
approved these changes
Jul 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 2a9bcd6)
Hailong-am
added a commit
that referenced
this pull request
Jul 3, 2023
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 19, 2023
…arch-project#843) Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 2a9bcd6) Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#835
Description of changes:
Remove onetime notification setting when index operation complete
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.