-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI on JDK 8, 11, and 14. #130
Conversation
Signed-off-by: dblock <dblock@dblock.org>
17Failing with
8Failing with
@reta Any ideas here? Seems like for 8 it means having to go and build OpenSearch gradle extensions with JDK 8, and for 17 I am not sure. |
@dblock ahhh ... here we are, Gradle 6.x does not support JDK-17 .... (in core we use JDK-11 to run Gradle but then JDK-17 is "injected" to run tests) and indeed,
so artifacts are not consumable by JDK-8 |
Do you know how or have any ideas how to solve this for a plugin?
I could change that to 8, would that make sense/work? |
We need Gradle 7+ but it won't work for 1.3 :( since the
We could try, yeah, I don't know the prehistory of JDK-10 compatibility sadly |
@reta would you give up on using JDK17 at runtime for 1.3.0? Note that we also found opensearch-project/security#1653 |
@dblock Gradle 7 is a major blocker here, going with 11 for 1.3 looks acceptable, moreover we know right now that some plugins are not compatible with JDK-17 (and not sure about JDK-16 since the reflective access started to tighten there). |
Yep :( I've edited opensearch-project/opensearch-plugins#64 to reflect what we think we want in 1.3.0. |
Signed-off-by: dblock <dblock@dblock.org>
I tried this again now that we have 1.8 binaries, and for the life of me I cannot figure out where this
I also tried building 11 and running tests on 8, but can't get compilation for the @reta ideas? |
@dblock found it [1], let me send the PR ... |
Signed-off-by: dblock <dblock@dblock.org>
Signed-off-by: dblock <dblock@dblock.org>
Updated this PR to build on 8, 11 and 14. Punting 17 for post 1.3.0 when we upgrade to Gradle 7 and drop JDK8. |
@dblock JDK-8 is green, but for JDK-17 we may need a stretch with Gradle 7 ... I could submit the change but we need to branch off 2.0 or/and 1.x |
We'll do this part of 2.0. |
* Run CI on JDK 8, 11, 14 and 17. Signed-off-by: dblock <dblock@dblock.org> * Build with 11 and test on 8. Signed-off-by: dblock <dblock@dblock.org> * Build and test using JDK 8. Signed-off-by: dblock <dblock@dblock.org> * Remove JDK17, requires Gradle 7. Signed-off-by: dblock <dblock@dblock.org>
Signed-off-by: dblock dblock@dblock.org
Description
Copy-paste from opensearch-project/common-utils#121.
Issues Resolved
Closes #103.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.