Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.sh script to include optional platform param #99

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

gaiksaya
Copy link
Member

Signed-off-by: Sayali Gaikawad gaiksaya@amazon.com

Description

Add optional platform param sent by build workflow. This param is optional in this script but will always be sent by the workflow.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and please do backport this to other branches!

@dblock dblock requested a review from peternied November 12, 2021 14:49
@peternied peternied merged commit 47e07b0 into opensearch-project:main Nov 12, 2021
@gaiksaya
Copy link
Member Author

gaiksaya commented Nov 15, 2021

Thanks and please do backport this to other branches!

Is back-porting to 1.1 enough or are there more?

@gaiksaya gaiksaya deleted the build branch November 15, 2021 20:12
@dblock
Copy link
Member

dblock commented Nov 15, 2021

Thanks and please do backport this to other branches!

Is back-porting to 1.1 enough or are there more?

Should be enough for now.

gaiksaya added a commit to gaiksaya/job-scheduler-1 that referenced this pull request Nov 15, 2021
amitgalitz pushed a commit to amitgalitz/job-scheduler that referenced this pull request Feb 2, 2022
downsrob pushed a commit to downsrob/job-scheduler that referenced this pull request Feb 2, 2022
downsrob added a commit that referenced this pull request Feb 2, 2022
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants