Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OnDiskInvertedLists file path for windows patching #1044

Merged

Conversation

naveentatikonda
Copy link
Member

@naveentatikonda naveentatikonda commented Aug 15, 2023

Description

Fix OnDiskInvertedLists.cpp file path to apply patching on Windows OS

> Task :windowsPatches
Get-Content : Cannot find path
'C:\Users\Administrator\AppData\Local\Temp\2\tmp0ado2fyq\k-NN\jni\external\faiss\faiss\OnDiskInvertedLists.cpp'
because it does not exist.
At C:\Users\Administrator\AppData\Local\Temp\2\tmp0ado2fyq\k-NN\scripts\windowsScript.ps1:29 char:2
+ (Get-Content jni/external/faiss/faiss/OnDiskInvertedLists.cpp).replac ...
+  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\Admini...vertedLists.cpp:String) [Get-Content], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetContentCommand

You cannot call a method on a null-valued expression.
At C:\Users\Administrator\AppData\Local\Temp\2\tmp0ado2fyq\k-NN\scripts\windowsScript.ps1:29 char:1
+ (Get-Content jni/external/faiss/faiss/OnDiskInvertedLists.cpp).replac ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [], RuntimeException
    + FullyQualifiedErrorId : InvokeMethodOnNull

Issues Resolved

#1040

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@naveentatikonda
Copy link
Member Author

Our Windows CI is still not working. I validated this change on Windows RDP.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@naveentatikonda naveentatikonda merged commit 9702dd0 into opensearch-project:main Aug 16, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 16, 2023
peterzhuamazon pushed a commit that referenced this pull request Aug 16, 2023
(cherry picked from commit 9702dd0)

Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants