-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore_unmapped support in KNNQueryBuilder #1071
Add ignore_unmapped support in KNNQueryBuilder #1071
Conversation
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1071 +/- ##
============================================
- Coverage 85.01% 84.96% -0.06%
- Complexity 1184 1192 +8
============================================
Files 159 159
Lines 4813 4842 +29
Branches 433 440 +7
============================================
+ Hits 4092 4114 +22
- Misses 525 530 +5
- Partials 196 198 +2
|
This isn't quite ready for review yet, I still need to add tests |
you can create PR as "draft" so CI will be triggered, and when you're done with coding just flip status to "Ready for review" |
I had it as draft, then accidentally clicked on ready for review before I remembered about adding tests. |
Ready for review now |
@ryanbogan before review start can you see why the github WFs are failings. and fix them |
@navneet1v The Linux failure is for the test For the others, I was informed during standup that the tests with the security plugin enabled are currently broken. |
Can we rerun the workflows. Secure cluster I know is broken. But lets fix the changelog step, by adding this change in CHANGELOG.md file |
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have doubt about this change being backward compatible in its current form, please make sure BWC tests are passing
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment overall code looks good.
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
5dd9780
into
opensearch-project:main
Description
Add ignore_unmapped support in KNNQueryBuilder
Issues Resolved
#1018
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.