Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bytebuddy version to match OpenSearch core #1135

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

ryanbogan
Copy link
Member

Description

Upgrades bytebuddy version to match OpenSearch core

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1135 (909c48e) into main (3173b8a) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1135      +/-   ##
============================================
- Coverage     85.24%   85.01%   -0.23%     
+ Complexity     1189     1184       -5     
============================================
  Files           159      159              
  Lines          4813     4813              
  Branches        433      433              
============================================
- Hits           4103     4092      -11     
- Misses          516      525       +9     
- Partials        194      196       +2     

see 2 files with indirect coverage changes

@martin-gaievski
Copy link
Member

is this for main only, or we should port it to 2.x?

@ryanbogan
Copy link
Member Author

is this for main only, or we should port it to 2.x?

Looks like it's only on main as of right now, so we shouldn't backport yet: https://github.com/opensearch-project/OpenSearch/blob/4563ebc0750599651a513c4df10f2d7464bee2e9/buildSrc/version.properties#L54

@martin-gaievski martin-gaievski merged commit 0f93430 into opensearch-project:main Sep 18, 2023
43 of 49 checks passed
@ryanbogan ryanbogan deleted the upgrade_bytebuddy branch September 18, 2023 18:05
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 2, 2023
* Bump bytebuddy version to match OpenSearch core

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
(cherry picked from commit 0f93430)
heemin32 pushed a commit that referenced this pull request Oct 2, 2023
* Bump bytebuddy version to match OpenSearch core

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
(cherry picked from commit 0f93430)

Co-authored-by: Ryan Bogan <10944539+ryanbogan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants