Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use jdk-21 #1288

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

jmazanec15
Copy link
Member

Description

This updates the CI system to use jdk-21, which is latest LTS supported version.

Issues Resolved

Coming from opensearch-project/OpenSearch#10334

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15 jmazanec15 added Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. skip-changelog labels Nov 2, 2023
vamshin
vamshin previously approved these changes Nov 2, 2023
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

This updates the CI system to use jdk-21, which is latest LTS supported version.
Coming from opensearch-project/OpenSearch#10334

Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1288 (07ffa97) into main (fa57b4b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 07ffa97 differs from pull request most recent head 2106daa. Consider uploading reports for the commit 2106daa to get more accurate results

@@             Coverage Diff              @@
##               main    #1288      +/-   ##
============================================
+ Coverage     85.07%   85.13%   +0.06%     
  Complexity     1210     1210              
============================================
  Files           160      160              
  Lines          4930     4931       +1     
  Branches        449      449              
============================================
+ Hits           4194     4198       +4     
+ Misses          540      537       -3     
  Partials        196      196              
Files Coverage Δ
...main/java/org/opensearch/knn/indices/ModelDao.java 82.74% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 merged commit c72f096 into opensearch-project:main Nov 7, 2023
42 of 47 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2023
This updates the CI system to use jdk-21, which is latest LTS supported version.
Coming from opensearch-project/OpenSearch#10334

Signed-off-by: John Mazanec <jmazane@amazon.com>
(cherry picked from commit c72f096)
jmazanec15 added a commit that referenced this pull request Nov 7, 2023
This updates the CI system to use jdk-21, which is latest LTS supported version.
Coming from opensearch-project/OpenSearch#10334

Signed-off-by: John Mazanec <jmazane@amazon.com>
(cherry picked from commit c72f096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants