Add more description about running OpenSearch on MAC M1 to developer guide #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guide Signed-off-by: gaobinlong <gbinlong@amazon.com>
gaobinlong
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1302 +/- ##
=========================================
Coverage 85.13% 85.13%
Complexity 1210 1210
=========================================
Files 160 160
Lines 4931 4931
Branches 449 449
=========================================
Hits 4198 4198
Misses 537 537
Partials 196 196 |
ryanbogan
reviewed
Nov 9, 2023
Signed-off-by: gaobinlong <gbinlong@amazon.com>
heemin32
approved these changes
Nov 13, 2023
ryanbogan
approved these changes
Nov 17, 2023
|
LGTM! Thanks for the contribution! |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
…guide (#1302) * Add more description about running OpenSearch on MAC M1 to developer guide Signed-off-by: gaobinlong <gbinlong@amazon.com> * Change some wording Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> (cherry picked from commit aef2d26)
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running OpenSearch with knn plugin on MAC M1, we need to build the JNI library such as faiss, nmslib manually, but if we don't use JDK for ARM, then we can see the error
mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64')when executing knn search. And if we start OpenSearch by running./bin/opensearchdirectly on MAC M1 and do not set the environment variableJAVA_LIBRARY_PATH, then OpenSearch cannot find the JNI library. We need to add more description about how to run OpenSearchon MAC M1 to make it clear for users.Issues Resolved
#580
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.