Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix script to pick up correct zip #1592

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Fix script to pick up correct zip #1592

merged 1 commit into from
Apr 5, 2024

Conversation

jmazanec15
Copy link
Member

Description

Fix find command to look in correct place. This broke because micro-benchmarks ends up producing a zip in the build/distributions folder.

Locally:

Without fix:

$ find "$(pwd)" -path \*build/distributions/*.zip
<PATH>/k-NN-1/micro-benchmarks/build/distributions/micro-benchmarks-2.14.0.0-SNAPSHOT.zip
<PATH>/k-NN-1/build/distributions/opensearch-knn-3.0.0.0-SNAPSHOT.zip

With fix

$ find "$(pwd)/build/distributions" -path \*.zip
<PATH>/k-NN-1/build/distributions/opensearch-knn-3.0.0.0-SNAPSHOT.zip

Issues Resolved

#1591 #1585

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15 jmazanec15 added Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. backport 2.x labels Apr 5, 2024
@jmazanec15
Fix script to pick up correct zip
832bc26 
Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15
Copy link
Member Author

Flaky failures #1593

@jmazanec15 jmazanec15 merged commit 653e7eb into opensearch-project:main Apr 5, 2024
40 of 52 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2024
@jmazanec15 @github-actions
Fix script to pick up correct zip (#1592)
5231bd3 
Signed-off-by: John Mazanec <jmazane@amazon.com>
(cherry picked from commit 653e7eb)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junqiu-lei junqiu-lei junqiu-lei approved these changes

@vibrantvarun vibrantvarun vibrantvarun approved these changes

@navneet1v navneet1v navneet1v approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

Assignees
No one assigned
Labels
backport 2.x Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmazanec15 @navneet1v @vibrantvarun @junqiu-lei