Ensure gcc is newer >= 11.2.1 < 12.0.0 when building knn lib #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added
Enhancements
This was referenced Apr 29, 2024
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
changed the title
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
jmazanec15
approved these changes
Apr 30, 2024
junqiu-lei
approved these changes
Apr 30, 2024
|
Build might fail because of #1668. Non-blocker this will fix it. |
naveentatikonda
approved these changes
Apr 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit da4cd1c)
peterzhuamazon
added a commit
to peterzhuamazon/k-NN
that referenced
this pull request
Apr 30, 2024
…pensearch-project#1664)" This reverts commit da4cd1c. Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
5 tasks
navneet1v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Revert "Ensure gcc is newer >= 11.2.1 < 12.0.0 when building knn lib (#1664)" This reverts commit da4cd1c. Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Revert "Update gcc restrictions to version 12.0.0 (#1634)" This reverts commit 11342be. Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Revert "Ensure gcc is newer >= 11.2.1 < 12.0.0 when building knn lib (#1664)" This reverts commit da4cd1c. Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Revert "Update gcc restrictions to version 12.0.0 (#1634)" This reverts commit 11342be. Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit f432b0e)
peterzhuamazon
added a commit
that referenced
this pull request
Apr 30, 2024
* Revert "Ensure gcc is newer >= 11.2.1 < 12.0.0 when building knn lib (#1664)" This reverts commit da4cd1c. Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Revert "Update gcc restrictions to version 12.0.0 (#1634)" This reverts commit 11342be. Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit f432b0e) Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure gcc is newer >= 11.2.1 < 12.0.0 when building knn lib
Issues Resolved
opensearch-project/opensearch-build#4379 (comment)
opensearch-project/opensearch-build#4379 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.