[Backport 2.17] Makes sure KNNVectorValues aren't recreated unnecessarily when quantization isn't needed (#2133) #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shatejas
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
naveentatikonda
previously approved these changes
Sep 24, 2024
navneet1v
changed the title
shatejas
force-pushed
the
backport/backport-2133-to-2.17
branch
from
4e98c64 to
18e0c2c
Compare
navneet1v
reviewed
Sep 24, 2024
| @@ -20,6 +20,7 @@ Compatible with OpenSearch 2.17.0 | |||
| * Fix memory overflow caused by cache behavior [#2015](https://github.com/opensearch-project/k-NN/pull/2015) | |||
| * Use correct type for binary vector in ivf training [#2086](https://github.com/opensearch-project/k-NN/pull/2086) | |||
| * Switch MINGW32 to MINGW64 [#2090](https://github.com/opensearch-project/k-NN/pull/2090) | |||
| * * Does not create additional KNNVectorValues in NativeEngines990KNNVectorWriter when quantization is not needed [#2133](https://github.com/opensearch-project/k-NN/pull/2133) | |||
There was a problem hiding this comment.
there should be only * here. @shatejas
…zation isn't needed (opensearch-project#2133) Signed-off-by: Tejas Shah <shatejas@amazon.com> (cherry picked from commit e33afa5)
shatejas
force-pushed
the
backport/backport-2133-to-2.17
branch
from
18e0c2c to
1131be0
Compare
62 tasks
navneet1v
approved these changes
Sep 25, 2024
naveentatikonda
approved these changes
Sep 27, 2024
naveentatikonda
merged commit ca6b03f
into
opensearch-project:2.17
96 of 97 checks passed
naveentatikonda
added a commit
to naveentatikonda/k-NN
that referenced
this pull request
Sep 27, 2024
…n quantization isn't needed (opensearch-project#2133) (opensearch-project#2140)" This reverts commit ca6b03f.
naveentatikonda
added a commit
to naveentatikonda/k-NN
that referenced
this pull request
Sep 27, 2024
…n quantization isn't needed (opensearch-project#2133) (opensearch-project#2140)" This reverts commit ca6b03f. Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
added a commit
that referenced
this pull request
Sep 27, 2024
navneet1v
added a commit
to navneet1v/k-NN
that referenced
this pull request
Sep 28, 2024
…en quantization isn't needed (opensearch-project#2133) (opensearch-project#2140)" (opensearch-project#2161) This reverts commit b0d82b7. Signed-off-by: Navneet Verma <navneev@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Backport 2.17] Makes sure KNNVectorValues aren't recreated unnecessarily when quantization isn't needed (#2133)
Signed-off-by: Tejas Shah shatejas@amazon.com
(cherry picked from commit e33afa5)
Description
Backport PR for #2133
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.