Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warn logs for engine deprecation #2495

Merged

Conversation

kotwanikunal
Copy link
Member

Description

  • Fixes log flooding for engine deprecation notice

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@navneet1v navneet1v merged commit c8b6637 into opensearch-project:2.x Feb 6, 2025
95 of 99 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-2495-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c8b6637b7322bfa03e71908104023bf32d28b9c7
# Push it to GitHub
git push --set-upstream origin backport/backport-2495-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-2495-to-main.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2025
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit c8b6637)
navneet1v pushed a commit that referenced this pull request Feb 6, 2025
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit c8b6637)

Co-authored-by: Kunal Kotwani <kkotwani@amazon.com>
kotwanikunal added a commit to kotwanikunal/k-NN that referenced this pull request Feb 6, 2025
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants