Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Benchmark] Remove ingest results collection #272

Merged
merged 2 commits into from
Jan 28, 2022
Merged

[Benchmark] Remove ingest results collection #272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b83b02d
[Benchmark] Remove ingest results collection
jmazanec15 Jan 28, 2022
788f09b
Add descriptive comment
jmazanec15 Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions benchmarks/perf-tool/okpt/test/steps/steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,14 +287,14 @@ def _action(self):
def action(doc_id):
return {'index': {'_index': self.index_name, '_id': doc_id}}

index_responses = []
# Maintain minimal state outside of this loop. For large data sets, too
# much state may cause out of memory failure
for i in range(0, self.doc_count, self.bulk_size):
partition = self.dataset.read(self.bulk_size)
if partition is None:
break
body = bulk_transform(partition, self.field_name, action, i)
result = bulk_index(self.opensearch, self.index_name, body)
index_responses.append(result)
bulk_index(self.opensearch, self.index_name, body)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it makes sense to document our decision with a code comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes will add

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!


self.dataset.reset()

Expand Down