Refactor BWC tests into sub project #359
Conversation
Creates new sub project for BWC testing. This will allow us to modularize the build files better. Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #359 +/- ##
=========================================
Coverage 84.01% 84.01%
Complexity 911 911
=========================================
Files 130 130
Lines 3879 3879
Branches 359 359
=========================================
Hits 3259 3259
Misses 458 458
Partials 162 162 Continue to review full report at Codecov.
|
| String knn_bwc_version = System.getProperty("bwc.version") | ||
|
|
||
| // Task to pull k-NN plugin from archive | ||
| task pullBwcPlugin { |
There was a problem hiding this comment.
I feel like this section is unix os specific, can be a bummer in case we want to support something like win platform. did you try to find gradle native equivalent plugins/functions?
There was a problem hiding this comment.
Let me take a look. For this specific project, given that we have only supportted Linux, I dont think it is blocking us. However, I will take a look for gradle tasks/functions that doe something similar.
There was a problem hiding this comment.
sure, for us it works and isn't a blocker. it's more for customers on win or other non-unix like platforms. If it something that doesn't require a lot of efforts I think we need to do to that direction.
| @@ -4,6 +4,7 @@ | |||
| # | |||
|
|
|||
| version=1.0.0 | |||
| systemProp.bwc.version=1.3.1 | |||
There was a problem hiding this comment.
please make sure it's covered in plugin release guide
There was a problem hiding this comment.
Will update release guide
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
|
Looks good, there are multiple farther improvements possible, as discussed offline they are out of scope for this PR. Thank you! |
Description
This PR clean up our build.gradle file. First, it refactors BWC tests into a subproject - :qa:bwc. This is how OpenSearch does it and will give independence between our integration test suite and BWC tests. In addition to this, I setup a BWC task to pull the OpenSeacrh release artifact and extract a zip of the k-NN plugin (addressing #320).
In order to share test code between the root project and the bwc project, I moved helper classes into a testfixtures source set. I would like to get feedback/thoughts on this. I would like to know if there is a better way to do this that I may not be thinking of?
I removed OSPackage code at the bottom of the main build.gradle file as it was no longer in used (we do not use it to build RPMs/DEBs).
Along with this, I changed the knncoverage to only apply to the rootproject.
Issues Resolved
#320
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.